You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/19 06:55:25 UTC

[GitHub] [beam] mosche opened a new pull request, #17389: [BEAM-14323] Improve IDE integration of Spark cross version builds

mosche opened a new pull request, #17389:
URL: https://github.com/apache/beam/pull/17389

   With the current build setup, developer experience is fairly poor when working with the cross version build for Spark (but also similarly for Flink):
   
   - Sources for version specific overrides are copied to a new location and defined as Gradle sources at that location. 
     1) First of all, this is totally unnecessary. These sources are not shared and should be used in place. 
     2) Much more troublesome, the actual sources won't be resolved / checked by any IDE anymore and can't be properly worked on that way. Sadly for no reason at all ...
   - The actual shared resources on the other hand are referenced (added to srcDirs) in place. The IDE will randomly assign them to one Spark version module. Typically, for IntelliJ at least, that's the first (lower) one and not the one developers are actively working on.
   
   The suggested changes in this PR are:
   - Don't copy version specific overrides
   - Only copy shared sources conditionally based on a flag. This allows developers to disable copying to pick a primary version they intend to work on.
   
   Note: This is primary a cosmetic flag to improve IDE integration and has no impact on builds, even if all modules disable copying.
   
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] mosche commented on a diff in pull request #17389: [BEAM-14323] Improve IDE integration of Spark cross version builds

Posted by GitBox <gi...@apache.org>.
mosche commented on code in PR #17389:
URL: https://github.com/apache/beam/pull/17389#discussion_r854072813


##########
runners/spark/2/build.gradle:
##########
@@ -22,12 +22,7 @@ project.ext {
   // Set the version of all Spark-related dependencies here.
   spark_version = '2.4.8'
   spark_scala_version = '2.11'
-
-  // Version specific code overrides.
-  main_source_overrides = ['./src/main/java']
-  test_source_overrides = ['./src/test/java']
-  main_resources_overrides = []
-  test_resources_overrides = []
+  copySourceBase = true // enabled to use Spark 3 as primary dev version

Review Comment:
   👍 I've rephrased the comment



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] aromanenko-dev commented on a diff in pull request #17389: [BEAM-14323] Improve IDE integration of Spark cross version builds

Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on code in PR #17389:
URL: https://github.com/apache/beam/pull/17389#discussion_r853989632


##########
runners/spark/spark_runner.gradle:
##########
@@ -49,67 +49,46 @@ configurations {
 }
 
 def hadoopVersions = [
-    "285": "2.8.5",

Review Comment:
   What caused so many indent-related fixes in this PR here and below?



##########
runners/spark/2/build.gradle:
##########
@@ -22,12 +22,7 @@ project.ext {
   // Set the version of all Spark-related dependencies here.
   spark_version = '2.4.8'
   spark_scala_version = '2.11'
-
-  // Version specific code overrides.
-  main_source_overrides = ['./src/main/java']
-  test_source_overrides = ['./src/test/java']
-  main_resources_overrides = []
-  test_resources_overrides = []
+  copySourceBase = true // enabled to use Spark 3 as primary dev version

Review Comment:
   Is it a typo here? Should it be `Spark2`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] aromanenko-dev commented on pull request #17389: [BEAM-14323] Improve IDE integration of Spark cross version builds

Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on PR #17389:
URL: https://github.com/apache/beam/pull/17389#issuecomment-1103791832

   Run Spark ValidatesRunner


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] mosche commented on pull request #17389: [BEAM-14323] Improve IDE integration of Spark cross version builds

Posted by GitBox <gi...@apache.org>.
mosche commented on PR #17389:
URL: https://github.com/apache/beam/pull/17389#issuecomment-1102323410

   R: @jbonofre 
   R: @echauchot 
   R: @aromanenko-dev 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] mosche commented on pull request #17389: [BEAM-14323] Improve IDE integration of Spark cross version builds

Posted by GitBox <gi...@apache.org>.
mosche commented on PR #17389:
URL: https://github.com/apache/beam/pull/17389#issuecomment-1103761571

   R: @lukecwik 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] aromanenko-dev commented on a diff in pull request #17389: [BEAM-14323] Improve IDE integration of Spark cross version builds

Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on code in PR #17389:
URL: https://github.com/apache/beam/pull/17389#discussion_r854044561


##########
runners/spark/2/build.gradle:
##########
@@ -22,12 +22,7 @@ project.ext {
   // Set the version of all Spark-related dependencies here.
   spark_version = '2.4.8'
   spark_scala_version = '2.11'
-
-  // Version specific code overrides.
-  main_source_overrides = ['./src/main/java']
-  test_source_overrides = ['./src/test/java']
-  main_resources_overrides = []
-  test_resources_overrides = []
+  copySourceBase = true // enabled to use Spark 3 as primary dev version

Review Comment:
   Maybe choose another name for that then? It sounds a bit ambiguous now for me. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] aromanenko-dev merged pull request #17389: [BEAM-14323] Improve IDE integration of Spark cross version builds

Posted by GitBox <gi...@apache.org>.
aromanenko-dev merged PR #17389:
URL: https://github.com/apache/beam/pull/17389


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] aromanenko-dev commented on pull request #17389: [BEAM-14323] Improve IDE integration of Spark cross version builds

Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on PR #17389:
URL: https://github.com/apache/beam/pull/17389#issuecomment-1103832228

   CC: @ibzib 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] mosche commented on a diff in pull request #17389: [BEAM-14323] Improve IDE integration of Spark cross version builds

Posted by GitBox <gi...@apache.org>.
mosche commented on code in PR #17389:
URL: https://github.com/apache/beam/pull/17389#discussion_r854035790


##########
runners/spark/2/build.gradle:
##########
@@ -22,12 +22,7 @@ project.ext {
   // Set the version of all Spark-related dependencies here.
   spark_version = '2.4.8'
   spark_scala_version = '2.11'
-
-  // Version specific code overrides.
-  main_source_overrides = ['./src/main/java']
-  test_source_overrides = ['./src/test/java']
-  main_resources_overrides = []
-  test_resources_overrides = []
+  copySourceBase = true // enabled to use Spark 3 as primary dev version

Review Comment:
   nup, Spark 3 should be the primary version for development ... so we copy sources for Spark 2



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] mosche commented on a diff in pull request #17389: [BEAM-14323] Improve IDE integration of Spark cross version builds

Posted by GitBox <gi...@apache.org>.
mosche commented on code in PR #17389:
URL: https://github.com/apache/beam/pull/17389#discussion_r854036105


##########
runners/spark/spark_runner.gradle:
##########
@@ -49,67 +49,46 @@ configurations {
 }
 
 def hadoopVersions = [
-    "285": "2.8.5",

Review Comment:
   auto code formatting



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org