[jira] Resolved: (TAPESTRY-1229) AssetService not thread safe

["Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org>]

     [ https://issues.apache.org/jira/browse/TAPESTRY-1229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jesse Kuhnert resolved TAPESTRY-1229.
-------------------------------------

    Resolution: Fixed
      Assignee: Jesse Kuhnert

Thanks for the issue / steps to resolve. Pretty much did what you said verbatim. (as it worked out on the other regexp issue)

> AssetService not thread safe
> ----------------------------
>
>                 Key: TAPESTRY-1229
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1229
>             Project: Tapestry
>          Issue Type: Bug
>          Components: Core, Framework
>    Affects Versions: 4.1.1
>            Reporter: Greg Woolsey
>         Assigned To: Jesse Kuhnert
>            Priority: Blocker
>             Fix For: 4.1.2
>
>
> AssetService declares this field:
>     static final DateFormat CACHED_FORMAT = new SimpleDateFormat("EEE, d MMM yyyy HH:mm:ss Z", Locale.ENGLISH);
> However, DateFormat objects are explicitly NOT thread safe.  We've encountered this in our in-house concurrency testing.  We'll have to patch our local 4.1.1 to fix this before deploying our application.
> a quick search did not find any other references to SimpleDateFormat that look like they could have the same issue.
> A simple CommonsPool object pool of date format objects would fix the problem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org