You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@empire-db.apache.org by Rainer Döbele <do...@esteam.de> on 2009/02/08 12:42:10 UTC
getGeneratedKeys
Hi Francis,
I have checked in my modifications now to support getGeneratedKeys().
You should be able just to remove the getPostInsertAutoIncValue() completely and it should work.
Please let me know if this works with your drivers.
Regards
Rainer
Re: getGeneratedKeys
Posted by Francis De Brabandere <fr...@gmail.com>.
and one more thing, I think there is still to much copy paste code if
you compare all drivers, we should try to clean that up in the future
On Sun, Feb 8, 2009 at 3:07 PM, Francis De Brabandere
<fr...@gmail.com> wrote:
> further I suggest nobody else submits to the maven branch so that I
> know how to handle the merge
>
> On Sun, Feb 8, 2009 at 3:06 PM, Francis De Brabandere
> <fr...@gmail.com> wrote:
>> Ok, I'll submit my drivers to trunk and update the demo app config for
>> the new drivers
>>
>> On Sun, Feb 8, 2009 at 3:03 PM, Rainer Döbele <do...@esteam.de> wrote:
>>>
>>> Thanks Francis.
>>> I know I should be on the Maven branch already - unfortunately I am still a bit short on time. But for me it's OK to merge the branches ASAP.
>>>
>>> I was hoping to hear something from Jörg about this.
>>> I would wait another week and then call for a vote whether to merge the branches or not.
>>> If nobody objects (which I am confident of) we can proceed.
>>>
>>> Regards
>>> Rainer
>>>
>>> Francis De Brabandere wrote:
>>>> Re: getGeneratedKeys
>>>>
>>>> I applied your changes on the maven branch as well as I'm working on
>>>> the branch, but I'll submit the drivers to trunk when I'm done.
>>>>
>>>> I'm writing unit tests on the maven branch I think it's better if we
>>>> all move to maven as soon as possible (otherwise it'll become very
>>>> hard to merge stuff afterwards)
>>>>
>>>>
>>>> On Sun, Feb 8, 2009 at 1:08 PM, Francis De Brabandere
>>>> <fr...@gmail.com> wrote:
>>>> > Ok, will have a look at it later today
>>>> >
>>>> > On Sun, Feb 8, 2009 at 12:42 PM, Rainer Döbele <do...@esteam.de> wrote:
>>>> >> Hi Francis,
>>>> >>
>>>> >> I have checked in my modifications now to support getGeneratedKeys().
>>>> >>
>>>> >> You should be able just to remove the getPostInsertAutoIncValue() completely and it > should work.
>>>> >>
>>>> >> Please let me know if this works with your drivers.
>>>> >>
>>>> >> Regards
>>>> >> Rainer
>>>> >>
>>>> >>
>>>> >
>>>> > --
>>>> > http://www.somatik.be
>>>> > Microsoft gives you windows, Linux gives you the whole house.
>>>> >
>>>
>>
>>
>>
>> --
>> http://www.somatik.be
>> Microsoft gives you windows, Linux gives you the whole house.
>>
>
>
>
> --
> http://www.somatik.be
> Microsoft gives you windows, Linux gives you the whole house.
>
--
http://www.somatik.be
Microsoft gives you windows, Linux gives you the whole house.
Re: getGeneratedKeys
Posted by Francis De Brabandere <fr...@gmail.com>.
further I suggest nobody else submits to the maven branch so that I
know how to handle the merge
On Sun, Feb 8, 2009 at 3:06 PM, Francis De Brabandere
<fr...@gmail.com> wrote:
> Ok, I'll submit my drivers to trunk and update the demo app config for
> the new drivers
>
> On Sun, Feb 8, 2009 at 3:03 PM, Rainer Döbele <do...@esteam.de> wrote:
>>
>> Thanks Francis.
>> I know I should be on the Maven branch already - unfortunately I am still a bit short on time. But for me it's OK to merge the branches ASAP.
>>
>> I was hoping to hear something from Jörg about this.
>> I would wait another week and then call for a vote whether to merge the branches or not.
>> If nobody objects (which I am confident of) we can proceed.
>>
>> Regards
>> Rainer
>>
>> Francis De Brabandere wrote:
>>> Re: getGeneratedKeys
>>>
>>> I applied your changes on the maven branch as well as I'm working on
>>> the branch, but I'll submit the drivers to trunk when I'm done.
>>>
>>> I'm writing unit tests on the maven branch I think it's better if we
>>> all move to maven as soon as possible (otherwise it'll become very
>>> hard to merge stuff afterwards)
>>>
>>>
>>> On Sun, Feb 8, 2009 at 1:08 PM, Francis De Brabandere
>>> <fr...@gmail.com> wrote:
>>> > Ok, will have a look at it later today
>>> >
>>> > On Sun, Feb 8, 2009 at 12:42 PM, Rainer Döbele <do...@esteam.de> wrote:
>>> >> Hi Francis,
>>> >>
>>> >> I have checked in my modifications now to support getGeneratedKeys().
>>> >>
>>> >> You should be able just to remove the getPostInsertAutoIncValue() completely and it > should work.
>>> >>
>>> >> Please let me know if this works with your drivers.
>>> >>
>>> >> Regards
>>> >> Rainer
>>> >>
>>> >>
>>> >
>>> > --
>>> > http://www.somatik.be
>>> > Microsoft gives you windows, Linux gives you the whole house.
>>> >
>>
>
>
>
> --
> http://www.somatik.be
> Microsoft gives you windows, Linux gives you the whole house.
>
--
http://www.somatik.be
Microsoft gives you windows, Linux gives you the whole house.
Re: getGeneratedKeys
Posted by Francis De Brabandere <fr...@gmail.com>.
Ok, I'll submit my drivers to trunk and update the demo app config for
the new drivers
On Sun, Feb 8, 2009 at 3:03 PM, Rainer Döbele <do...@esteam.de> wrote:
>
> Thanks Francis.
> I know I should be on the Maven branch already - unfortunately I am still a bit short on time. But for me it's OK to merge the branches ASAP.
>
> I was hoping to hear something from Jörg about this.
> I would wait another week and then call for a vote whether to merge the branches or not.
> If nobody objects (which I am confident of) we can proceed.
>
> Regards
> Rainer
>
> Francis De Brabandere wrote:
>> Re: getGeneratedKeys
>>
>> I applied your changes on the maven branch as well as I'm working on
>> the branch, but I'll submit the drivers to trunk when I'm done.
>>
>> I'm writing unit tests on the maven branch I think it's better if we
>> all move to maven as soon as possible (otherwise it'll become very
>> hard to merge stuff afterwards)
>>
>>
>> On Sun, Feb 8, 2009 at 1:08 PM, Francis De Brabandere
>> <fr...@gmail.com> wrote:
>> > Ok, will have a look at it later today
>> >
>> > On Sun, Feb 8, 2009 at 12:42 PM, Rainer Döbele <do...@esteam.de> wrote:
>> >> Hi Francis,
>> >>
>> >> I have checked in my modifications now to support getGeneratedKeys().
>> >>
>> >> You should be able just to remove the getPostInsertAutoIncValue() completely and it > should work.
>> >>
>> >> Please let me know if this works with your drivers.
>> >>
>> >> Regards
>> >> Rainer
>> >>
>> >>
>> >
>> > --
>> > http://www.somatik.be
>> > Microsoft gives you windows, Linux gives you the whole house.
>> >
>
--
http://www.somatik.be
Microsoft gives you windows, Linux gives you the whole house.
re: getGeneratedKeys
Posted by Rainer Döbele <do...@esteam.de>.
Thanks Francis.
I know I should be on the Maven branch already - unfortunately I am still a bit short on time. But for me it's OK to merge the branches ASAP.
I was hoping to hear something from Jörg about this.
I would wait another week and then call for a vote whether to merge the branches or not.
If nobody objects (which I am confident of) we can proceed.
Regards
Rainer
Francis De Brabandere wrote:
> Re: getGeneratedKeys
>
> I applied your changes on the maven branch as well as I'm working on
> the branch, but I'll submit the drivers to trunk when I'm done.
>
> I'm writing unit tests on the maven branch I think it's better if we
> all move to maven as soon as possible (otherwise it'll become very
> hard to merge stuff afterwards)
>
>
> On Sun, Feb 8, 2009 at 1:08 PM, Francis De Brabandere
> <fr...@gmail.com> wrote:
> > Ok, will have a look at it later today
> >
> > On Sun, Feb 8, 2009 at 12:42 PM, Rainer Döbele <do...@esteam.de> wrote:
> >> Hi Francis,
> >>
> >> I have checked in my modifications now to support getGeneratedKeys().
> >>
> >> You should be able just to remove the getPostInsertAutoIncValue() completely and it > should work.
> >>
> >> Please let me know if this works with your drivers.
> >>
> >> Regards
> >> Rainer
> >>
> >>
> >
> > --
> > http://www.somatik.be
> > Microsoft gives you windows, Linux gives you the whole house.
> >
Re: getGeneratedKeys
Posted by Francis De Brabandere <fr...@gmail.com>.
seems postgresql does not support the return autogenerated keys :-s
The database operation failed. Native error is Returning autogenerated
keys is not supported..
so I implemented it the same way as the oracle driver but we have two
more options:
* set the default for the column to nextval('<seqname>') and request
the value after insert using SELECT currval('<sequence-name>');
* use the INSERT...RETURNING construction and handle the insert resultset:
http://www.blahstuff.com/oldstuff/2007/02/22/611/postgresql-insert-returning/
the h2 and derby drivers are working correctly with the new code
On Sun, Feb 8, 2009 at 1:50 PM, Francis De Brabandere
<fr...@gmail.com> wrote:
> I applied your changes on the maven branch as well as I'm working on
> the branch, but I'll submit the drivers to trunk when I'm done.
>
> I'm writing unit tests on the maven branch I think it's better if we
> all move to maven as soon as possible (otherwise it'll become very
> hard to merge stuff afterwards)
>
>
> On Sun, Feb 8, 2009 at 1:08 PM, Francis De Brabandere
> <fr...@gmail.com> wrote:
>> Ok, will have a look at it later today
>>
>> On Sun, Feb 8, 2009 at 12:42 PM, Rainer Döbele <do...@esteam.de> wrote:
>>> Hi Francis,
>>>
>>> I have checked in my modifications now to support getGeneratedKeys().
>>>
>>> You should be able just to remove the getPostInsertAutoIncValue() completely and it should work.
>>>
>>> Please let me know if this works with your drivers.
>>>
>>> Regards
>>> Rainer
>>>
>>>
>>
>>
>>
>> --
>> http://www.somatik.be
>> Microsoft gives you windows, Linux gives you the whole house.
>>
>
>
>
> --
> http://www.somatik.be
> Microsoft gives you windows, Linux gives you the whole house.
>
--
http://www.somatik.be
Microsoft gives you windows, Linux gives you the whole house.
Re: getGeneratedKeys
Posted by Francis De Brabandere <fr...@gmail.com>.
I applied your changes on the maven branch as well as I'm working on
the branch, but I'll submit the drivers to trunk when I'm done.
I'm writing unit tests on the maven branch I think it's better if we
all move to maven as soon as possible (otherwise it'll become very
hard to merge stuff afterwards)
On Sun, Feb 8, 2009 at 1:08 PM, Francis De Brabandere
<fr...@gmail.com> wrote:
> Ok, will have a look at it later today
>
> On Sun, Feb 8, 2009 at 12:42 PM, Rainer Döbele <do...@esteam.de> wrote:
>> Hi Francis,
>>
>> I have checked in my modifications now to support getGeneratedKeys().
>>
>> You should be able just to remove the getPostInsertAutoIncValue() completely and it should work.
>>
>> Please let me know if this works with your drivers.
>>
>> Regards
>> Rainer
>>
>>
>
>
>
> --
> http://www.somatik.be
> Microsoft gives you windows, Linux gives you the whole house.
>
--
http://www.somatik.be
Microsoft gives you windows, Linux gives you the whole house.
Re: getGeneratedKeys
Posted by Francis De Brabandere <fr...@gmail.com>.
Ok, will have a look at it later today
On Sun, Feb 8, 2009 at 12:42 PM, Rainer Döbele <do...@esteam.de> wrote:
> Hi Francis,
>
> I have checked in my modifications now to support getGeneratedKeys().
>
> You should be able just to remove the getPostInsertAutoIncValue() completely and it should work.
>
> Please let me know if this works with your drivers.
>
> Regards
> Rainer
>
>
--
http://www.somatik.be
Microsoft gives you windows, Linux gives you the whole house.