[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #3518: Exposing simple UI action to open next segment of a heap dump

[GitBox <gi...@apache.org>]

JaroslavTulach commented on a change in pull request #3518:
URL: https://github.com/apache/netbeans/pull/3518#discussion_r793209564



##########
File path: profiler/lib.profiler/src/org/netbeans/lib/profiler/heap/CacheDirectory.java
##########
@@ -28,16 +28,19 @@
  */
 class CacheDirectory {
     
-    private static final String DIR_EXT = ".hwcache";   // NOI18N
+    private static final String DIR_EXT = ".nbcache";   // NOI18N

Review comment:
       This change is useful to avoid clash between Apache NetBeans profiler library and VisualVM profiler library. Both of these libraries are derived from NetBeans 8.2 profiler library, but evolve independently. Sharing the same directory leads to errors like:
   ```
   java.io.IOException: Invalid HPROF version 3 loaded 2
           at ...HprofHeap.<init>(HprofHeap.java)
           at ...HeapFactory.loadHeap(HeapFactory.java)
           at ...HeapFactory.createHeap(HeapFactory.java)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists