[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #291: view: permission check, section display

[GitBox <gi...@apache.org>]

rhtyd commented on a change in pull request #291: view: permission check, section display
URL: https://github.com/apache/cloudstack-primate/pull/291#discussion_r408301422
 
 

 ##########
 File path: src/store/modules/permission.js
 ##########
 @@ -20,11 +20,12 @@ import { asyncRouterMap, constantRouterMap } from '@/config/router'
 function hasApi (apis, route) {
   if (route.meta && route.meta.permission) {
     for (const permission of route.meta.permission) {
-      if (apis.includes(permission)) {
-        return true
+      console.log(route.meta.name, permission)
 
 Review comment:
   @shwstppr could this make permissions too strict; we've use this to show views when we want any of the APIs allowed in the list. Let's discuss tomorrow.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services