[GitHub] [trafficserver] maskit commented on pull request #9101: Fix handling of OPTIONS request

[GitBox <gi...@apache.org>]

maskit commented on PR #9101:
URL: https://github.com/apache/trafficserver/pull/9101#issuecomment-1281771997

   > But I don't think ATS knows if it's making a forward-proxy request. You can configure it to make an absolute-uri request, but that could be a forward proxy or direct origin request, there's no way to know that from the config.
   
   Isn't that a protocol violation? If ATS is making an absolute-form request, that must be a request for a proxy.
   
   [3.2.1](https://datatracker.ietf.org/doc/html/rfc9112#section-3.2.1).  origin-form
   >    When making a request directly to an origin server, other than a
      CONNECT or server-wide OPTIONS request (as detailed below), a client
      MUST send only the absolute path and query components of the target
      URI as the request-target.
   
   [3.2.2](https://datatracker.ietf.org/doc/html/rfc9112#section-3.2.2).  absolute-form
   >    When making a request to a proxy, other than a CONNECT or server-wide
      OPTIONS request (as detailed below), a client MUST send the target
      URI in "absolute-form" as the request-target.
   
   I'm not familiar with parent.config/strategies.yaml so I'm unsure if ATS can tell a request is for a proxy or an origin server, but we should make it possible to be compliant with the spec.
   
   > To be clear, I wasn't objecting, just looking for input. This PR is an improvement, regardless of RFC9112§3.2.4.
   
   Ok, I'm going to update the code as per @SolidWallOfCode 's suggestion if we are fine with the hacky special character.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org