You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/27 09:28:27 UTC
[GitHub] [camel-website] AemieJ opened a new pull request #277: make the
split in Apache & opensource look neat on front-page
AemieJ opened a new pull request #277: make the split in Apache & opensource look neat on front-page
URL: https://github.com/apache/camel-website/pull/277
* Within the **Apache & Opensource** section on the front page, the paragraph written doesn't have any margin surrounding it making the design look unstructured for the mobile view.
* Thus, I added a margin surrounding the split session for the front page to look structured and neat for the mobile view.
### BEFORE
### AFTER
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] AemieJ commented on a change in pull request #277:
make the split in Apache & opensource look neat on front-page
Posted by GitBox <gi...@apache.org>.
AemieJ commented on a change in pull request #277: make the split in Apache & opensource look neat on front-page
URL: https://github.com/apache/camel-website/pull/277#discussion_r400335642
##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -235,6 +235,7 @@ section.frontpage h1 {
@media screen and (max-width: 626px) {
.split {
flex: 100%;
+ margin: 3%;
Review comment:
I used a fixed margin by adjusting the **margin-left**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] AemieJ commented on issue #277: make the split in
Apache & opensource look neat on front-page
Posted by GitBox <gi...@apache.org>.
AemieJ commented on issue #277: make the split in Apache & opensource look neat on front-page
URL: https://github.com/apache/camel-website/pull/277#issuecomment-605211983
@Akhila499 this isn't an issue. I made this change to improve the structure of Frontpage in the mobile view.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] AemieJ commented on a change in pull request #277:
make the split in Apache & opensource look neat on front-page
Posted by GitBox <gi...@apache.org>.
AemieJ commented on a change in pull request #277: make the split in Apache & opensource look neat on front-page
URL: https://github.com/apache/camel-website/pull/277#discussion_r400331699
##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -235,6 +235,7 @@ section.frontpage h1 {
@media screen and (max-width: 626px) {
.split {
flex: 100%;
+ margin: 3%;
Review comment:
I would try it to fix it with rem and used a fixed margin.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#277: make the split in Apache & opensource look neat on front-page
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #277: make the split in Apache & opensource look neat on front-page
URL: https://github.com/apache/camel-website/pull/277#discussion_r400328452
##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -235,6 +235,7 @@ section.frontpage h1 {
@media screen and (max-width: 626px) {
.split {
flex: 100%;
+ margin: 3%;
Review comment:
Perhaps a fixed margin would work better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] Akhila499 commented on issue #277: make the split
in Apache & opensource look neat on front-page
Posted by GitBox <gi...@apache.org>.
Akhila499 commented on issue #277: make the split in Apache & opensource look neat on front-page
URL: https://github.com/apache/camel-website/pull/277#issuecomment-605210653
Hi @AemieJ,
I am an outreachy applicant and want to solve this bug. Is this available for solving?..
If available, please guide me.Hoping i get a reply form you.
Thanks,
Akhila
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] AemieJ opened a new pull request #277: make the
split in Apache & opensource look neat on front-page
Posted by GitBox <gi...@apache.org>.
AemieJ opened a new pull request #277: make the split in Apache & opensource look neat on front-page
URL: https://github.com/apache/camel-website/pull/277
* Within the **Apache & Opensource** section on the front page, the paragraph written doesn't have any margin surrounding it making the design look unstructured for the mobile view.
* Thus, I added a margin surrounding the split session for the front page to look structured and neat for the mobile view.
### BEFORE
### AFTER
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #277: make the split in
Apache & opensource look neat on front-page
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #277: make the split in Apache & opensource look neat on front-page
URL: https://github.com/apache/camel-website/pull/277#issuecomment-607974057
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] AemieJ closed pull request #277: make the split in
Apache & opensource look neat on front-page
Posted by GitBox <gi...@apache.org>.
AemieJ closed pull request #277: make the split in Apache & opensource look neat on front-page
URL: https://github.com/apache/camel-website/pull/277
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart merged pull request #277: make the split
in Apache & opensource look neat on front-page
Posted by GitBox <gi...@apache.org>.
zregvart merged pull request #277: make the split in Apache & opensource look neat on front-page
URL: https://github.com/apache/camel-website/pull/277
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services