Re: [lucy-dev] [GitHub] lucy pull request: Remove clownfish

[Nick Wellnhofer <we...@aevum.de>]

On 22/03/2014 20:17, Nick Wellnhofer wrote:
> On Mar 22, 2014, at 01:28 , timwilkens <gi...@git.apache.org> wrote:
>
>> GitHub user timwilkens opened a pull request:
>>
>>     https://github.com/apache/lucy/pull/5
>>
>>     Remove clownfish
>>
>>     Remove Clownfish from the Lucy repository. This branch eliminates the Perl bindings' dependency on the bundled Clownfish directory.
>>
>>     After applying this patch sequence both the Perl bindings and the C bindings build without error.
>>
>>     Marvin Humphrey and I collaborated on this patch sequence.
>
> I get the following failure:
>
> Parcel 'Clownfish' required by 'Lucy' not found at /Library/Perl/5.16/darwin-thread-multi-2level/Clownfish/CFC/Perl/Build.pm line 233.
>
> It seems that the system-wide Clownfish include dir for Perl doesn’t get added to the search path. I do this for my sample extension in Build.PL:
>
> https://github.com/nwellnhof/LucyX-Analysis-WhitespaceTokenizer/blob/master/perl/Build.PL
>
> But this should probably be done in Clownfish::CFC::Perl::Build.

I'm really blocking on this. If I don't hear any objections, I'll finish the 
Clownfish removal myself.

Nick

Re: [lucy-dev] [GitHub] lucy pull request: Remove clownfish

[Marvin Humphrey <ma...@rectangular.com>]

On Wed, Apr 9, 2014 at 10:07 AM, Nick Wellnhofer <we...@aevum.de> wrote:

>> I get the following failure:
>>
>> Parcel 'Clownfish' required by 'Lucy' not found at
>> /Library/Perl/5.16/darwin-thread-multi-2level/Clownfish/CFC/Perl/Build.pm
>> line 233.
>>
>> It seems that the system-wide Clownfish include dir for Perl doesn't get
>> added to the search path. I do this for my sample extension in Build.PL:
>>
>>
>> https://github.com/nwellnhof/LucyX-Analysis-WhitespaceTokenizer/blob/master/perl/Build.PL
>>
>> But this should probably be done in Clownfish::CFC::Perl::Build.
>
>
> I'm really blocking on this. If I don't hear any objections, I'll finish the
> Clownfish removal myself.

I'm at ApacheCon and just gave my second talk this morning.  I could
work on this tomorrow solo, but won't be able to collaborate with Tim
until next week. I took a stab already and the changes don't seem too
big but have tricky testing interactions to validate correctness.

So, Nick, if you want to finish out the fixes and get the process
unblocked we'd be grateful.  No objections from this quarter -- only
thanks.

Marvin Humphrey