You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/06/27 12:26:01 UTC

[GitHub] [incubator-nuttx] gustavonihei commented on pull request #6511: esp32_board_spi:Missing Data Command pin support

gustavonihei commented on PR #6511:
URL: https://github.com/apache/incubator-nuttx/pull/6511#issuecomment-1167289377

   > The commit is fine. I have decided to withdrawn possibility of configuration LCD Command/Data pin. The reason is following: it is necessary to modify all boards.h files in esp32 directory. Possibility of configuration Command/Data pin after writing menu config is confusing, because it is still required proper modification of board.h file for every new BSP. Unfortunately there is no "master" board.h file for every eps32 board.
   
   The changes on this PR are specific to a single board, why would the change from this PR affect the `board.h` for every BSP?
   Neither of the ESP32-based boards already supported in NuttX provides this e-ink display out-of-the-box, so they shouldn't be affect.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org