You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/22 22:44:51 UTC
[GitHub] [incubator-superset] mistercrunch commented on issue #8976:
[SIP-34] Proposal to establish a new design direction, system,
and process for Superset
mistercrunch commented on issue #8976: [SIP-34] Proposal to establish a new design direction, system, and process for Superset
URL: https://github.com/apache/incubator-superset/issues/8976#issuecomment-577421521
Clearly Superset is very deep into `react-bootstrap` now (103 references in the codebase) and we'll need to tweak/bend it and in cases just deviate from it to get closer to this north star, as needed. I think that generally using the bootstrap-defined classes conventions seems reasonable to me (`panel`, `table`, `form`, `btn`, `btn-sm`, ...). In many cases `react-bootstrap` is simply wrapping/exposing classes as components and/or props. If we commit loosely to the bootstrap CSS conventions, we may not have to touch many of the `react-bootstrap` components for a moment, and iterate slowly towards the look and feel proposed here.
Maybe this is shortsighted, but a decent percentage of the theme-related-work to make Superset look like the design suggested in this SIP can be done directly in the existing files under `superset/assets/stylesheets/less/`.
One big question is whether we want to make the theme somewhat environment or user-tunable. We'd like to enable admins and/or users to define their brand colors / palettes, navbar logo, and some other aspects of how things look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org