[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #4844: 【Improvement】Avoid null host when forward to master

[GitBox <gi...@apache.org>]

EmmyMiao87 commented on a change in pull request #4844:
URL: https://github.com/apache/incubator-doris/pull/4844#discussion_r517878321



##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/MasterOpExecutor.java
##########
@@ -63,6 +63,9 @@ public void execute() throws Exception {
     private void forward() throws Exception {
         String masterHost = ctx.getCatalog().getMasterIp();
         int masterRpcPort = ctx.getCatalog().getMasterRpcPort();
+        if (masterHost == "" || masterRpcPort == 0) {

Review comment:
       Maybe this is better. Put it at the beginning.
   ```
   if (!ctx.getCatalog().isReady()) {
       thrown new Exception("Node catalog is not ready, please wait for a while");
   }
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org