You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2023/09/13 16:00:49 UTC
[GitHub] [incubator-opendal] Xuanwo opened a new pull request, #3057: ci(binding/java): Enable release when OPENDAL_RELEASE is on
Xuanwo opened a new pull request, #3057:
URL: https://github.com/apache/incubator-opendal/pull/3057
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #3057: ci(binding/java): Enable release when OPENDAL_RELEASE is on
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3057:
URL: https://github.com/apache/incubator-opendal/pull/3057#issuecomment-1717938453
> If so, perhaps `--release` or not doesn't make too many changes?
Maybe not as good as I expected, but will be faster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] tisonkun merged pull request #3057: ci(binding/java): Enable release when OPENDAL_RELEASE is on
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #3057:
URL: https://github.com/apache/incubator-opendal/pull/3057
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #3057: ci(binding/java): Enable release when OPENDAL_RELEASE is on
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #3057:
URL: https://github.com/apache/incubator-opendal/pull/3057#discussion_r1324755423
##########
bindings/java/tools/build.py:
##########
@@ -54,7 +55,11 @@ def get_cargo_artifact_name(classifier: str) -> str:
parser.add_argument('--classifier', type=str, required=True)
args = parser.parse_args()
- cmd = ['cargo', 'build', '--color=always', '--release']
+ cmd = ['cargo', 'build', '--color=always']
+
+ # Only enable release build while OPENDAL_RELEASE is on.
+ if os.environ.get('OPENDAL_RELEASE') == 'on':
Review Comment:
Yep, build java binding requires 36m on windows at GHA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #3057: ci(binding/java): Enable release when OPENDAL_RELEASE is on
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3057:
URL: https://github.com/apache/incubator-opendal/pull/3057#issuecomment-1717934583
I will split the php related logic to a new PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] tisonkun commented on pull request #3057: ci(binding/java): Enable release when OPENDAL_RELEASE is on
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #3057:
URL: https://github.com/apache/incubator-opendal/pull/3057#issuecomment-1717939881
OK. Ping me when you factor out the PHP changes. I'll push my solution on this branch then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] tisonkun commented on a diff in pull request #3057: ci(binding/java): Enable release when OPENDAL_RELEASE is on
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #3057:
URL: https://github.com/apache/incubator-opendal/pull/3057#discussion_r1324751513
##########
bindings/java/tools/build.py:
##########
@@ -54,7 +55,11 @@ def get_cargo_artifact_name(classifier: str) -> str:
parser.add_argument('--classifier', type=str, required=True)
args = parser.parse_args()
- cmd = ['cargo', 'build', '--color=always', '--release']
+ cmd = ['cargo', 'build', '--color=always']
+
+ # Only enable release build while OPENDAL_RELEASE is on.
+ if os.environ.get('OPENDAL_RELEASE') == 'on':
Review Comment:
Is this to speed up build on developing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #3057: ci(binding/java): Enable release when OPENDAL_RELEASE is on
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3057:
URL: https://github.com/apache/incubator-opendal/pull/3057#issuecomment-1717926544
> Let me prepare a patch for this issue. We can use an argument over env var, which is how we currently work.
You can push to this branch directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #3057: ci(binding/java): Enable release when OPENDAL_RELEASE is on
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3057:
URL: https://github.com/apache/incubator-opendal/pull/3057#issuecomment-1717930028
Ok, I know the root cause: we are building rocksdb.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #3057: ci(binding/java): Enable release when OPENDAL_RELEASE is on
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3057:
URL: https://github.com/apache/incubator-opendal/pull/3057#issuecomment-1717940585
> OK. Ping me when you factor out the PHP changes. I'll push my solution on this branch then.
https://github.com/apache/incubator-opendal/issues/3055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] tisonkun commented on pull request #3057: ci(binding/java): Enable release when OPENDAL_RELEASE is on
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #3057:
URL: https://github.com/apache/incubator-opendal/pull/3057#issuecomment-1717936833
> Ok, I know the root cause: we are building rocksdb.
If so, perhaps `--release` or not doesn't make too many changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #3057: ci(binding/java): Enable release when OPENDAL_RELEASE is on
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3057:
URL: https://github.com/apache/incubator-opendal/pull/3057#issuecomment-1717945650
On linux 22m -> 15m (alought it's failed for wrong dylib path)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org