You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/06/30 05:19:04 UTC
[GitHub] [incubator-devlake] warren830 opened a new pull request, #2392: fix(jira): change filter for jira_issues
warren830 opened a new pull request, #2392:
URL: https://github.com/apache/incubator-devlake/pull/2392
# Summary
change filter for _tool_jira_issues
### Does this close any open issues?
closes #2386
### Screenshots
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 merged pull request #2392: fix(jira): change filter for jira_issues
Posted by GitBox <gi...@apache.org>.
warren830 merged PR #2392:
URL: https://github.com/apache/incubator-devlake/pull/2392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on a diff in pull request #2392: fix(jira): change filter for jira_issues
Posted by GitBox <gi...@apache.org>.
klesh commented on code in PR #2392:
URL: https://github.com/apache/incubator-devlake/pull/2392#discussion_r910851919
##########
plugins/jira/tasks/issue_convertor.go:
##########
@@ -50,7 +50,7 @@ func ConvertIssues(taskCtx core.SubTaskContext) error {
dal.From(jiraIssue),
dal.Join("left join _tool_jira_board_issues on _tool_jira_board_issues.issue_id = _tool_jira_issues.issue_id"),
dal.Where(
- "_tool_jira_board_issues.connection_id = ? AND _tool_jira_board_issues.board_id = ?",
+ "_tool_jira_issues.connection_id = ? AND _tool_jira_board_issues.board_id = ?",
Review Comment:
This doesn't seem legit.
We should modify the `Join` condition rather than `Where` condition
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #2392: fix(jira): change filter for jira_issues
Posted by GitBox <gi...@apache.org>.
warren830 commented on code in PR #2392:
URL: https://github.com/apache/incubator-devlake/pull/2392#discussion_r910862975
##########
plugins/jira/tasks/issue_convertor.go:
##########
@@ -50,7 +50,7 @@ func ConvertIssues(taskCtx core.SubTaskContext) error {
dal.From(jiraIssue),
dal.Join("left join _tool_jira_board_issues on _tool_jira_board_issues.issue_id = _tool_jira_issues.issue_id"),
dal.Where(
- "_tool_jira_board_issues.connection_id = ? AND _tool_jira_board_issues.board_id = ?",
+ "_tool_jira_issues.connection_id = ? AND _tool_jira_board_issues.board_id = ?",
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org