You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Auston McReynolds (JIRA)" <ji...@codehaus.org> on 2007/07/17 19:25:13 UTC
[jira] Created: (MECLIPSE-307) "target" for deploy-path shouldnt be
a constant
"target" for deploy-path shouldnt be a constant
-----------------------------------------------
Key: MECLIPSE-307
URL: http://jira.codehaus.org/browse/MECLIPSE-307
Project: Maven 2.x Eclipse Plugin
Issue Type: Bug
Components: WTP support
Affects Versions: 2.4, 2.5
Environment: Windows 2003
Reporter: Auston McReynolds
If specified in the POM:
<build>
<sourceDirectory>JavaSource</sourceDirectory>
<outputDirectory>AnotherFolder/WEB-INF/classes</outputDirectory>
<plugins>
<plugin>
<artifactId>maven-eclipse-plugin</artifactId>
...
.settings/org.eclipse.wst.common.component has
<wb-resource deploy-path="WEB-INF/classes" source-path="JavaSource"/>
Instead of
<wb-resource deploy-path="AnotherFolder/WEB-INF/classes" source-path="JavaSource"/>
This is due to String target being set to the literal "/WEB-INF/classes" under the block:
if ( "war".equalsIgnoreCase( packaging ) )
Instead it seems to me that it should be:
target = IdeUtils.toRelativeAndFixSeparator( config.getProject().getBasedir(), buildOutputDirectory, false );
Thanks to Dan and others for assistance received previously!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MECLIPSE-307) "target" for
deploy-path shouldnt be a constant
Posted by "Auston McReynolds (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_102530 ]
Auston McReynolds edited comment on MECLIPSE-307 at 7/17/07 5:41 PM:
---------------------------------------------------------------------
Patch for fix. I'm new to the JIRA experience, so I'll try to have a proper testcase drawn up later. Thanks.
was:
Patch for fix.
> "target" for deploy-path shouldnt be a constant
> -----------------------------------------------
>
> Key: MECLIPSE-307
> URL: http://jira.codehaus.org/browse/MECLIPSE-307
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.4, 2.5
> Environment: Windows 2003
> Reporter: Auston McReynolds
> Attachments: patch.txt
>
>
> If specified in the POM:
> <build>
> <sourceDirectory>JavaSource</sourceDirectory>
> <outputDirectory>AnotherFolder/WEB-INF/classes</outputDirectory>
> <plugins>
> <plugin>
> <artifactId>maven-eclipse-plugin</artifactId>
> ...
> .settings/org.eclipse.wst.common.component has
> <wb-resource deploy-path="WEB-INF/classes" source-path="JavaSource"/>
> Instead of
> <wb-resource deploy-path="AnotherFolder/WEB-INF/classes" source-path="JavaSource"/>
> This is due to String target being set to the literal "/WEB-INF/classes" under the block:
> if ( "war".equalsIgnoreCase( packaging ) )
> Instead it seems to me that it should be:
> target = IdeUtils.toRelativeAndFixSeparator( config.getProject().getBasedir(), buildOutputDirectory, false );
> Thanks to Dan and others for assistance received previously!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-307) "target" for deploy-path shouldnt be
a constant
Posted by "Auston McReynolds (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Auston McReynolds updated MECLIPSE-307:
---------------------------------------
Attachment: patch.txt
Patch for fix.
> "target" for deploy-path shouldnt be a constant
> -----------------------------------------------
>
> Key: MECLIPSE-307
> URL: http://jira.codehaus.org/browse/MECLIPSE-307
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.4, 2.5
> Environment: Windows 2003
> Reporter: Auston McReynolds
> Attachments: patch.txt
>
>
> If specified in the POM:
> <build>
> <sourceDirectory>JavaSource</sourceDirectory>
> <outputDirectory>AnotherFolder/WEB-INF/classes</outputDirectory>
> <plugins>
> <plugin>
> <artifactId>maven-eclipse-plugin</artifactId>
> ...
> .settings/org.eclipse.wst.common.component has
> <wb-resource deploy-path="WEB-INF/classes" source-path="JavaSource"/>
> Instead of
> <wb-resource deploy-path="AnotherFolder/WEB-INF/classes" source-path="JavaSource"/>
> This is due to String target being set to the literal "/WEB-INF/classes" under the block:
> if ( "war".equalsIgnoreCase( packaging ) )
> Instead it seems to me that it should be:
> target = IdeUtils.toRelativeAndFixSeparator( config.getProject().getBasedir(), buildOutputDirectory, false );
> Thanks to Dan and others for assistance received previously!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-307) "target" for deploy-path shouldnt
be a constant
Posted by "Dan Tran (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_102533 ]
Dan Tran commented on MECLIPSE-307:
-----------------------------------
I am not sure about your insentive of changing the default outputDirectory which should only effect 'java-output-path' property NOT 'deploy-path' in
wb-resource. The currently implementation has the correct behavior.
It seems you are looking a way to change deploy-path?
> "target" for deploy-path shouldnt be a constant
> -----------------------------------------------
>
> Key: MECLIPSE-307
> URL: http://jira.codehaus.org/browse/MECLIPSE-307
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.4, 2.5
> Environment: Windows 2003
> Reporter: Auston McReynolds
> Attachments: patch.txt
>
>
> If specified in the POM:
> <build>
> <sourceDirectory>JavaSource</sourceDirectory>
> <outputDirectory>AnotherFolder/WEB-INF/classes</outputDirectory>
> <plugins>
> <plugin>
> <artifactId>maven-eclipse-plugin</artifactId>
> ...
> .settings/org.eclipse.wst.common.component has
> <wb-resource deploy-path="WEB-INF/classes" source-path="JavaSource"/>
> Instead of
> <wb-resource deploy-path="AnotherFolder/WEB-INF/classes" source-path="JavaSource"/>
> This is due to String target being set to the literal "/WEB-INF/classes" under the block:
> if ( "war".equalsIgnoreCase( packaging ) )
> Instead it seems to me that it should be:
> target = IdeUtils.toRelativeAndFixSeparator( config.getProject().getBasedir(), buildOutputDirectory, false );
> Thanks to Dan and others for assistance received previously!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-307) "target" for deploy-path shouldnt
be a constant
Posted by "Dan Tran (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_102509 ]
Dan Tran commented on MECLIPSE-307:
-----------------------------------
patch + testcase will surely help
> "target" for deploy-path shouldnt be a constant
> -----------------------------------------------
>
> Key: MECLIPSE-307
> URL: http://jira.codehaus.org/browse/MECLIPSE-307
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.4, 2.5
> Environment: Windows 2003
> Reporter: Auston McReynolds
>
> If specified in the POM:
> <build>
> <sourceDirectory>JavaSource</sourceDirectory>
> <outputDirectory>AnotherFolder/WEB-INF/classes</outputDirectory>
> <plugins>
> <plugin>
> <artifactId>maven-eclipse-plugin</artifactId>
> ...
> .settings/org.eclipse.wst.common.component has
> <wb-resource deploy-path="WEB-INF/classes" source-path="JavaSource"/>
> Instead of
> <wb-resource deploy-path="AnotherFolder/WEB-INF/classes" source-path="JavaSource"/>
> This is due to String target being set to the literal "/WEB-INF/classes" under the block:
> if ( "war".equalsIgnoreCase( packaging ) )
> Instead it seems to me that it should be:
> target = IdeUtils.toRelativeAndFixSeparator( config.getProject().getBasedir(), buildOutputDirectory, false );
> Thanks to Dan and others for assistance received previously!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-307) "target" for deploy-path shouldnt
be a constant
Posted by "Auston McReynolds (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_102534 ]
Auston McReynolds commented on MECLIPSE-307:
--------------------------------------------
Correct. I assume the proper way to solve this would be to add a parameter along the lines of wtpContext?
> "target" for deploy-path shouldnt be a constant
> -----------------------------------------------
>
> Key: MECLIPSE-307
> URL: http://jira.codehaus.org/browse/MECLIPSE-307
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.4, 2.5
> Environment: Windows 2003
> Reporter: Auston McReynolds
> Attachments: patch.txt
>
>
> If specified in the POM:
> <build>
> <sourceDirectory>JavaSource</sourceDirectory>
> <outputDirectory>AnotherFolder/WEB-INF/classes</outputDirectory>
> <plugins>
> <plugin>
> <artifactId>maven-eclipse-plugin</artifactId>
> ...
> .settings/org.eclipse.wst.common.component has
> <wb-resource deploy-path="WEB-INF/classes" source-path="JavaSource"/>
> Instead of
> <wb-resource deploy-path="AnotherFolder/WEB-INF/classes" source-path="JavaSource"/>
> This is due to String target being set to the literal "/WEB-INF/classes" under the block:
> if ( "war".equalsIgnoreCase( packaging ) )
> Instead it seems to me that it should be:
> target = IdeUtils.toRelativeAndFixSeparator( config.getProject().getBasedir(), buildOutputDirectory, false );
> Thanks to Dan and others for assistance received previously!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-307) "target" for deploy-path shouldnt
be a constant
Posted by "Denis Cabasson (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_102951 ]
Denis Cabasson commented on MECLIPSE-307:
-----------------------------------------
The only valid path to deploy your compiled source in a web application is "WEB-INF/classes", so this path should certainly be hardcoded.
The outputDirectory is a maven parameter telling maven where to put compiled sources. Eclipse Java project is taking this path into account, but I don't think it would be good for Eclipse WTP to have a custom folder other than "WEB-INF/classes".
See [Java Servlet 2.2 Specifications|http://java.sun.com/products/servlet/2.2/], spécifications paper, point 9.4
> "target" for deploy-path shouldnt be a constant
> -----------------------------------------------
>
> Key: MECLIPSE-307
> URL: http://jira.codehaus.org/browse/MECLIPSE-307
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.4, 2.5
> Environment: Windows 2003
> Reporter: Auston McReynolds
> Attachments: patch.txt
>
>
> If specified in the POM:
> <build>
> <sourceDirectory>JavaSource</sourceDirectory>
> <outputDirectory>AnotherFolder/WEB-INF/classes</outputDirectory>
> <plugins>
> <plugin>
> <artifactId>maven-eclipse-plugin</artifactId>
> ...
> .settings/org.eclipse.wst.common.component has
> <wb-resource deploy-path="WEB-INF/classes" source-path="JavaSource"/>
> Instead of
> <wb-resource deploy-path="AnotherFolder/WEB-INF/classes" source-path="JavaSource"/>
> This is due to String target being set to the literal "/WEB-INF/classes" under the block:
> if ( "war".equalsIgnoreCase( packaging ) )
> Instead it seems to me that it should be:
> target = IdeUtils.toRelativeAndFixSeparator( config.getProject().getBasedir(), buildOutputDirectory, false );
> Thanks to Dan and others for assistance received previously!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MECLIPSE-307) "target" for deploy-path shouldnt be
a constant
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arnaud Heritier closed MECLIPSE-307.
------------------------------------
Assignee: Arnaud Heritier
Resolution: Won't Fix
As wrote in comments, there's no reason to change the deploy path. It is the directory where eclipse simulates in WTP the location of classes. It is always WEB-INF/classes for a webapp (webapp). The plugin now handles correctly [MECLIPSE-264, MECLIPSE-333] others deploy path for other web projects.
> "target" for deploy-path shouldnt be a constant
> -----------------------------------------------
>
> Key: MECLIPSE-307
> URL: http://jira.codehaus.org/browse/MECLIPSE-307
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.4, 2.5
> Environment: Windows 2003
> Reporter: Auston McReynolds
> Assignee: Arnaud Heritier
> Attachments: patch.txt
>
>
> If specified in the POM:
> <build>
> <sourceDirectory>JavaSource</sourceDirectory>
> <outputDirectory>AnotherFolder/WEB-INF/classes</outputDirectory>
> <plugins>
> <plugin>
> <artifactId>maven-eclipse-plugin</artifactId>
> ...
> .settings/org.eclipse.wst.common.component has
> <wb-resource deploy-path="WEB-INF/classes" source-path="JavaSource"/>
> Instead of
> <wb-resource deploy-path="AnotherFolder/WEB-INF/classes" source-path="JavaSource"/>
> This is due to String target being set to the literal "/WEB-INF/classes" under the block:
> if ( "war".equalsIgnoreCase( packaging ) )
> Instead it seems to me that it should be:
> target = IdeUtils.toRelativeAndFixSeparator( config.getProject().getBasedir(), buildOutputDirectory, false );
> Thanks to Dan and others for assistance received previously!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-307) "target" for deploy-path shouldnt
be a constant
Posted by "Dan Tran (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_102536 ]
Dan Tran commented on MECLIPSE-307:
-----------------------------------
see http://jira.codehaus.org/browse/MECLIPSE-299
> "target" for deploy-path shouldnt be a constant
> -----------------------------------------------
>
> Key: MECLIPSE-307
> URL: http://jira.codehaus.org/browse/MECLIPSE-307
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.4, 2.5
> Environment: Windows 2003
> Reporter: Auston McReynolds
> Attachments: patch.txt
>
>
> If specified in the POM:
> <build>
> <sourceDirectory>JavaSource</sourceDirectory>
> <outputDirectory>AnotherFolder/WEB-INF/classes</outputDirectory>
> <plugins>
> <plugin>
> <artifactId>maven-eclipse-plugin</artifactId>
> ...
> .settings/org.eclipse.wst.common.component has
> <wb-resource deploy-path="WEB-INF/classes" source-path="JavaSource"/>
> Instead of
> <wb-resource deploy-path="AnotherFolder/WEB-INF/classes" source-path="JavaSource"/>
> This is due to String target being set to the literal "/WEB-INF/classes" under the block:
> if ( "war".equalsIgnoreCase( packaging ) )
> Instead it seems to me that it should be:
> target = IdeUtils.toRelativeAndFixSeparator( config.getProject().getBasedir(), buildOutputDirectory, false );
> Thanks to Dan and others for assistance received previously!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira