You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/07 04:50:59 UTC
[GitHub] [airflow] josh-fell opened a new pull request #20093: Fix mypy errors in `tests/utils`
josh-fell opened a new pull request #20093:
URL: https://github.com/apache/airflow/pull/20093
Related: #19891
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #20093: Fix mypy errors in `tests/utils`
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #20093:
URL: https://github.com/apache/airflow/pull/20093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #20093: Fix mypy errors in `tests/utils`
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #20093:
URL: https://github.com/apache/airflow/pull/20093#discussion_r763668662
##########
File path: tests/utils/test_email.py
##########
@@ -273,7 +273,7 @@ def test_send_mime_dryrun(self, mock_smtp, mock_smtp_ssl):
@mock.patch('smtplib.SMTP_SSL')
@mock.patch('smtplib.SMTP')
- def test_send_mime_complete_failure(self, mock_smtp: mock, mock_smtp_ssl):
+ def test_send_mime_complete_failure(self, mock_smtp, mock_smtp_ssl):
Review comment:
Let’s annotate it correctly instead?
```suggestion
def test_send_mime_complete_failure(self, mock_smtp: mock.Mock, mock_smtp_ssl: mock.Mock):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org