You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "EdColeman (via GitHub)" <gi...@apache.org> on 2023/02/27 15:27:34 UTC

[GitHub] [accumulo] EdColeman commented on pull request #3202: replace sleepUninterruptibly, improve interrupt handling

EdColeman commented on PR #3202:
URL: https://github.com/apache/accumulo/pull/3202#issuecomment-1446538760

   The use of sleepUninterruptibly will wait for the entire duration of the sleep, which seems to be a case that should be rare in our code to be the desired behavior.  When that is truly intended we should make that explicit through the code and not as a side effect of the method. 
   
   In general, it felt like we are using sleepUninterruptibly excessively to avoid handling or re-throwing InterruptedException.  I was trying to move the code into a direction where we can improve InterruptException handling rather than assuming that the can be ignored.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org