[GitHub] [hadoop] Apache9 commented on a diff in pull request #4052: HADOOP-18088. Replace log4j 1.x with reload4j.

[GitBox <gi...@apache.org>]

Apache9 commented on code in PR #4052:
URL: https://github.com/apache/hadoop/pull/4052#discussion_r842251722


##########
hadoop-project/pom.xml:
##########
@@ -81,8 +81,8 @@
     <httpcore.version>4.4.13</httpcore.version>
 
     <!-- SLF4J/LOG4J version -->
-    <slf4j.version>1.7.30</slf4j.version>
-    <log4j.version>1.2.17</log4j.version>
+    <slf4j.version>1.7.35</slf4j.version>

Review Comment:
   1.7.36 is out?



##########
hadoop-project/pom.xml:
##########
@@ -2167,6 +2269,9 @@
                     <exclude>com.sun.jersey.jersey-test-framework:*</exclude>
                     <exclude>com.google.inject:guice</exclude>
                     <exclude>org.ow2.asm:asm</exclude>
+
+                    <exclude>org.slf4j:slf4j-log4j12</exclude>

Review Comment:
   Good.



##########
hadoop-client-modules/hadoop-client-check-test-invariants/pom.xml:
##########
@@ -89,7 +89,7 @@
                     <!-- Leave commons-logging unshaded so downstream users can configure logging. -->
                     <exclude>commons-logging:commons-logging</exclude>
                     <!-- Leave log4j unshaded so downstream users can configure logging. -->

Review Comment:
   log4j -> reload4j



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org