You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "lordgamez (via GitHub)" <gi...@apache.org> on 2023/03/21 08:21:13 UTC
[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request, #1537: MINIFICPP-1713 Fix transient segfault in RepoTests
lordgamez opened a new pull request, #1537:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1537
https://issues.apache.org/jira/browse/MINIFICPP-1713
-----------
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits closed pull request #1537: MINIFICPP-1713 Fix transient segfault in RepoTests
Posted by "fgerlits (via GitHub)" <gi...@apache.org>.
fgerlits closed pull request #1537: MINIFICPP-1713 Fix transient segfault in RepoTests
URL: https://github.com/apache/nifi-minifi-cpp/pull/1537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #1537: MINIFICPP-1713 Fix transient segfault in RepoTests
Posted by "szaszm (via GitHub)" <gi...@apache.org>.
szaszm commented on PR #1537:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1537#issuecomment-1477487173
Could you describe what caused the segfault and why this fixes it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #1537: MINIFICPP-1713 Fix transient segfault in RepoTests
Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on PR #1537:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1537#issuecomment-1477509409
> Could you describe what caused the segfault and why this fixes it?
Even though the `flush_counter` is an atomic, incrementing it and checking its value are 2 separate operations and running them in parallel could create an ordering where the checked value is never 1. This can occur quite often if this thread is run every 1ms. Because of this the repository is not stopped before it is destroyed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org