You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Jark Wu (Jira)" <ji...@apache.org> on 2020/04/28 11:36:00 UTC
[jira] [Created] (FLINK-17437) Use StringData instead of
BinaryStringData in code generation
Jark Wu created FLINK-17437:
-------------------------------
Summary: Use StringData instead of BinaryStringData in code generation
Key: FLINK-17437
URL: https://issues.apache.org/jira/browse/FLINK-17437
Project: Flink
Issue Type: Improvement
Components: Table SQL / Planner
Reporter: Jark Wu
In FLINK-16996, we force to use {{BinaryStringData}} instead of {{StringData}} in code generation. We hard cast StringData to BinaryStringData when {{RowData#getString}}. The motivation behind this is that this makes the code generator easily to generate opeartions based on string. There are too many invokings on the {{BinaryStringData}} now, if we use {{StringData}} in code generation, we have to refactor a lot of codes.
However, this may be worth to do. Because using the public interface {{StringData}} is more straightforword.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)