[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5968: minor: port some expr tests to sqllogictests, improve error message

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #5968:
URL: https://github.com/apache/arrow-datafusion/pull/5968#discussion_r1163279892


##########
datafusion/physical-expr/src/expressions/not.rs:
##########
@@ -77,8 +77,8 @@ impl PhysicalExpr for NotExpr {
             DataType::Int32 => Ok(DataType::Int32),
             DataType::Int64 => Ok(DataType::Int64),
             DataType::Null => Ok(DataType::Null),
-            _ => Err(DataFusionError::Internal(format!(
-                "Can't NOT or BITWISE_NOT datatype: '{:?}'",
+            _ => Err(DataFusionError::Plan(format!(

Review Comment:
   This can be hit with a bad user query, so it shouldn't be an Internal error



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org