You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/02/18 17:09:49 UTC

[GitHub] [solr] HoustonPutman opened a new pull request #652: SOLR-16021: Improve docs for S3 location option

HoustonPutman opened a new pull request #652:
URL: https://github.com/apache/solr/pull/652


   https://issues.apache.org/jira/browse/SOLR-16021


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] HoustonPutman merged pull request #652: SOLR-16021: Improve docs for S3 location option

Posted by GitBox <gi...@apache.org>.
HoustonPutman merged pull request #652:
URL: https://github.com/apache/solr/pull/652


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] HoustonPutman commented on a change in pull request #652: SOLR-16021: Improve docs for S3 location option

Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on a change in pull request #652:
URL: https://github.com/apache/solr/pull/652#discussion_r810231220



##########
File path: solr/solr-ref-guide/modules/deployment-guide/pages/backup-restore.adoc
##########
@@ -671,9 +671,27 @@ This plugin uses the https://docs.aws.amazon.com/sdk-for-java/v2/developer-guide
 
 [NOTE]
 ====
-When using the Backup & Restore Collections API Calls, you can provide a **location** that either starts with `s3://` or not.
-Either way, if your **location** (or s3 object prefix) starts with a `/`, it will be removed automatically.
-The repository does not allow backup locations that begin with a `/`.
+There are a few nuances to using the **`location`** option with the S3 Repository.
+The `location` option specifies the sub-directory to store backup information in.
+
+Location Format::
+When using the Backup & Restore Collections API Calls, the **`location`** option can be presented in a number of ways:
++
+* `dir/in/bucket`
+* `/dir/in/bucket`
+* `s3:/dir/in/bucket`
+* `s3://dir/in/bucket`
++
+All the above options will resolve to the same directory in your S3 Bucket: `dir/in/bucket`.
+
+Pre-Creation::
+The directory within your S3 bucket must already exist before you preform any backup operations with that location.

Review comment:
       `dir/in/bucket`
   
   Would this be clearer?
   
   `The location must already exist within your S3 bucket before you can preform any backup operations with that location.`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] madrob commented on a change in pull request #652: SOLR-16021: Improve docs for S3 location option

Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #652:
URL: https://github.com/apache/solr/pull/652#discussion_r810226694



##########
File path: solr/solr-ref-guide/modules/deployment-guide/pages/backup-restore.adoc
##########
@@ -671,9 +671,27 @@ This plugin uses the https://docs.aws.amazon.com/sdk-for-java/v2/developer-guide
 
 [NOTE]
 ====
-When using the Backup & Restore Collections API Calls, you can provide a **location** that either starts with `s3://` or not.
-Either way, if your **location** (or s3 object prefix) starts with a `/`, it will be removed automatically.
-The repository does not allow backup locations that begin with a `/`.
+There are a few nuances to using the **`location`** option with the S3 Repository.
+The `location` option specifies the sub-directory to store backup information in.
+
+Location Format::
+When using the Backup & Restore Collections API Calls, the **`location`** option can be presented in a number of ways:
++
+* `dir/in/bucket`
+* `/dir/in/bucket`
+* `s3:/dir/in/bucket`
+* `s3://dir/in/bucket`
++
+All the above options will resolve to the same directory in your S3 Bucket: `dir/in/bucket`.
+
+Pre-Creation::
+The directory within your S3 bucket must already exist before you preform any backup operations with that location.

Review comment:
       Does this mean that `dir/in` must exist or that `dir/in/bucket` must exist?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org