You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "Augustvic (GitHub)" <gi...@apache.org> on 2020/03/13 02:39:16 UTC
[GitHub] [dubbo] Augustvic opened pull request #5860:
EchoService.class will lose if the 'types' not null
## What is the purpose of the change
修正 2.6.x 版本中， AbstractProxyFactory 类的 getProxy(Invoker<T> invoker, boolean generic) 函数的一个小问题
## Brief changelog
按照既定的逻辑，interfaces 数组的前两个位置应该放的是接口类和 EchoService 类，也就是说 type 应该从第三个位置即 interfaces[2] 开始放，但是此处是从 interfaces[1] 开始放的。如果 types 不为 null，EchoService.class 将会被意外覆盖。
## Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/dubbo/pull/5860 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] codecov-io commented on issue #5860:
EchoService.class will lose if the 'types' not null
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5860?src=pr&el=h1) Report
> Merging [#5860](https://codecov.io/gh/apache/dubbo/pull/5860?src=pr&el=desc) into [2.6.x](https://codecov.io/gh/apache/dubbo/commit/bada690763c33e928f9c3aee5f06422a9d1b4766?src=pr&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/dubbo/pull/5860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 2.6.x #5860 +/- ##
============================================
- Coverage 47.46% 47.41% -0.06%
+ Complexity 4608 4430 -178
============================================
Files 577 566 -11
Lines 26509 25214 -1295
Branches 4691 4463 -228
============================================
- Hits 12582 11954 -628
+ Misses 12009 11418 -591
+ Partials 1918 1842 -76
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/5860?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../alibaba/dubbo/rpc/proxy/AbstractProxyFactory.java](https://codecov.io/gh/apache/dubbo/pull/5860/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvcHJveHkvQWJzdHJhY3RQcm94eUZhY3RvcnkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/dubbo/pull/5860/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2V4dGVuc2lvbi9TcHJpbmdFeHRlbnNpb25GYWN0b3J5LmphdmE=) | `75.67% <0%> (-8.11%)` | `9% <0%> (ø)` | |
| [...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/5860/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=) | `61.25% <0%> (-5%)` | `20% <0%> (-1%)` | |
| [...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/dubbo/pull/5860/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DaGFubmVsV3JhcHBlZEludm9rZXIuamF2YQ==) | `37.5% <0%> (-4.17%)` | `3% <0%> (ø)` | |
| [...ba/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/dubbo/pull/5860/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlTZXJ2ZXIuamF2YQ==) | `67.85% <0%> (-3.58%)` | `8% <0%> (-1%)` | |
| [.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java](https://codecov.io/gh/apache/dubbo/pull/5860/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9maWx0ZXIvRnV0dXJlRmlsdGVyLmphdmE=) | `54.54% <0%> (-2.03%)` | `13% <0%> (ø)` | |
| [.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/dubbo/pull/5860/diff?src=pr&el=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh) | `87.85% <0%> (-1.87%)` | `15% <0%> (ø)` | |
| [...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java](https://codecov.io/gh/apache/dubbo/pull/5860/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DYWxsYmFja1NlcnZpY2VDb2RlYy5qYXZh) | `77.2% <0%> (-1.48%)` | `29% <0%> (ø)` | |
| [...libaba/dubbo/rpc/protocol/dubbo/DubboProtocol.java](https://codecov.io/gh/apache/dubbo/pull/5860/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9EdWJib1Byb3RvY29sLmphdmE=) | `60.08% <0%> (-0.88%)` | `32% <0%> (-1%)` | |
| [.../java/com/alibaba/dubbo/common/json/JSONArray.java](https://codecov.io/gh/apache/dubbo/pull/5860/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2pzb24vSlNPTkFycmF5LmphdmE=) | | | |
| ... and [10 more](https://codecov.io/gh/apache/dubbo/pull/5860/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/5860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/5860?src=pr&el=footer). Last update [bada690...3f6ae5b](https://codecov.io/gh/apache/dubbo/pull/5860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo/pull/5860 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] chickenlj closed pull request #5860:
EchoService.class will lose if the 'types' not null
Posted by "chickenlj (GitHub)" <gi...@apache.org>.
[ pull request closed by chickenlj ]
[ Full content available at: https://github.com/apache/dubbo/pull/5860 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org