You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by "Valentyn Tymofieiev (JIRA)" <ji...@apache.org> on 2018/08/29 15:55:00 UTC

[jira] [Commented] (BEAM-5255) Fix over-aggressive division futurization.

    [ https://issues.apache.org/jira/browse/BEAM-5255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596524#comment-16596524 ] 

Valentyn Tymofieiev commented on BEAM-5255:
-------------------------------------------

We caught a several incorrect division conversion (done by a tool) in code reviews, but looks like we missed this one.

> Fix over-aggressive division futurization.
> ------------------------------------------
>
>                 Key: BEAM-5255
>                 URL: https://issues.apache.org/jira/browse/BEAM-5255
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>    Affects Versions: 2.6.0
>            Reporter: Robert Bradshaw
>            Assignee: Valentyn Tymofieiev
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> When converting from Python 2 to Python 3, `a / b` becomes `a // b` only for ints, but it is incorrect to do this substitution for floating point division. 
>  
> I noticed this change in the microbenchmarks, but we should do an audit to make sure we haven't broken things elsewhere. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)