[GitHub] [spark] HyukjinKwon commented on a change in pull request #25452: [SPARK-28710][SQL]to fix replace function, spark should call drop and create function

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #25452: [SPARK-28710][SQL]to fix replace function, spark should call drop and create function
URL: https://github.com/apache/spark/pull/25452#discussion_r358157347
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
 ##########
 @@ -82,8 +82,11 @@ case class CreateFunctionCommand(
     } else {
       // Handles `CREATE OR REPLACE FUNCTION AS ... USING ...`
       if (replace && catalog.functionExists(func.identifier)) {
-        // alter the function in the metastore
-        catalog.alterFunction(func)
 
 Review comment:
   Yeah, I think @viirya's point is valid. Isn't the root cause that `HiveExternalCatalog.alterFunction` does not handle? 
   
   > If this is for Hive only?
   
   I think he meant the behaviours at `InMemoryCatalog.alterFunction`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org