You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/29 23:27:35 UTC
[GitHub] [airflow] jedcunningham commented on a diff in pull request #26788: A few docs fixups
jedcunningham commented on code in PR #26788:
URL: https://github.com/apache/airflow/pull/26788#discussion_r984093581
##########
airflow/providers/ssh/hooks/ssh.py:
##########
@@ -50,7 +50,7 @@ class SSHHook(BaseHook):
:param ssh_conn_id: :ref:`ssh connection id<howto/connection:ssh>` from airflow
Connections from where all the required parameters can be fetched like
- username, password or key_file. Thought the priority is given to the
+ username, password or key_file. Though the priority is given to the
param passed during init
Review Comment:
```suggestion
username, password or key_file, though priority is given to the
params passed during init.
```
##########
airflow/providers/microsoft/winrm/hooks/winrm.py:
##########
@@ -40,7 +40,7 @@ class WinRMHook(BaseHook):
:param ssh_conn_id: connection id from airflow Connections from where
all the required parameters can be fetched like username and password.
Review Comment:
```suggestion
all the required parameters can be fetched like username and password,
```
##########
airflow/providers/microsoft/winrm/hooks/winrm.py:
##########
@@ -40,7 +40,7 @@ class WinRMHook(BaseHook):
:param ssh_conn_id: connection id from airflow Connections from where
all the required parameters can be fetched like username and password.
- Thought the priority is given to the param passed during init
+ Though the priority is given to the param passed during init
Review Comment:
```suggestion
though priority is given to the params passed during init.
```
Even better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org