You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "xiazcy (via GitHub)" <gi...@apache.org> on 2026/01/27 00:42:48 UTC
[PR] Go GLV added HTTP streaming & interceptors [tinkerpop]
xiazcy opened a new pull request, #3299:
URL: https://github.com/apache/tinkerpop/pull/3299
Added a streaming deserializer, combined httpProtocol/httpTransport into httpConnection, added interceptor mechanism which can replace AuthInfo, added basic & sigv4 auth interceptors, updated connection settings.
VOTE +1
<!--
Thanks for contributing! Reminders:
+ TARGET the earliest branch where you want the change
3.7-dev -> 3.7.6 (non-breaking only)
3.8-dev -> 3.8.1 (non-breaking only)
master -> 4.0.0
+ Committers will MERGE the PR forward to newer versions
+ ADD entry to the CHANGELOG.asciidoc for the targeted version
Do not reference a JIRA number there
+ ADD JIRA number to title and link in description
+ PRs requires 3 +1s from committers OR
1 +1 and 7 day wait to merge.
+ MORE details: https://s.apache.org/rtnal
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Go GLV added HTTP streaming & interceptors [tinkerpop]
Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu commented on code in PR #3299:
URL: https://github.com/apache/tinkerpop/pull/3299#discussion_r2776433223
##########
gremlin-go/driver/driverRemoteConnection.go:
##########
@@ -70,44 +80,46 @@ func NewDriverRemoteConnection(
LogVerbosity: Info,
Logger: &defaultLogger{},
Language: language.English,
- AuthInfo: &AuthInfo{},
TlsConfig: &tls.Config{},
- KeepAliveInterval: keepAliveIntervalDefault,
- WriteDeadline: writeDeadlineDefault,
ConnectionTimeout: connectionTimeoutDefault,
EnableCompression: false,
EnableUserAgentOnConnect: true,
- ReadBufferSize: readBufferSizeDefault,
- WriteBufferSize: writeBufferSizeDefault,
- MaximumConcurrentConnections: runtime.NumCPU(),
+ MaximumConcurrentConnections: 0, // Use default (128)
Review Comment:
This comment is kind of confusing to me. Why is the value 0 if the default is 128?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Go GLV added HTTP streaming & interceptors [tinkerpop]
Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy commented on code in PR #3299:
URL: https://github.com/apache/tinkerpop/pull/3299#discussion_r2785163333
##########
gremlin-go/driver/driverRemoteConnection.go:
##########
@@ -70,44 +80,46 @@ func NewDriverRemoteConnection(
LogVerbosity: Info,
Logger: &defaultLogger{},
Language: language.English,
- AuthInfo: &AuthInfo{},
TlsConfig: &tls.Config{},
- KeepAliveInterval: keepAliveIntervalDefault,
- WriteDeadline: writeDeadlineDefault,
ConnectionTimeout: connectionTimeoutDefault,
EnableCompression: false,
EnableUserAgentOnConnect: true,
- ReadBufferSize: readBufferSizeDefault,
- WriteBufferSize: writeBufferSizeDefault,
- MaximumConcurrentConnections: runtime.NumCPU(),
+ MaximumConcurrentConnections: 0, // Use default (128)
Review Comment:
This is for the zero value convention for applying defaults, which in this case is a constant applied in connection.go if the input value is 0, it's just to use that instead of writing the constant in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Go GLV added HTTP streaming & interceptors [tinkerpop]
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on PR #3299:
URL: https://github.com/apache/tinkerpop/pull/3299#issuecomment-3873243499
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Go GLV added HTTP streaming & interceptors [tinkerpop]
Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu commented on PR #3299:
URL: https://github.com/apache/tinkerpop/pull/3299#issuecomment-3863028739
VOTE +1, based on an overall design review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Go GLV added HTTP streaming & interceptors [tinkerpop]
Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy merged PR #3299:
URL: https://github.com/apache/tinkerpop/pull/3299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org