You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by yu...@apache.org on 2023/06/27 19:47:52 UTC
[thrift] 01/02: Fix spotlessJavaCheck failures
This is an automated email from the ASF dual-hosted git repository.
yuxuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/thrift.git
commit abf3fc31470daf57dc50085f56396abba4b3bc1d
Author: Yuxuan 'fishy' Wang <yu...@reddit.com>
AuthorDate: Tue Jun 27 10:04:09 2023 -0700
Fix spotlessJavaCheck failures
Those are failing CI for a while.
---
.../src/main/java/org/apache/thrift/protocol/TBinaryProtocol.java | 1 +
.../src/main/java/org/apache/thrift/protocol/TCompactProtocol.java | 1 +
.../main/java/org/apache/thrift/server/TThreadedSelectorServer.java | 4 ++++
.../src/main/java/org/apache/thrift/transport/TIOStreamTransport.java | 1 +
4 files changed, 7 insertions(+)
diff --git a/lib/java/src/main/java/org/apache/thrift/protocol/TBinaryProtocol.java b/lib/java/src/main/java/org/apache/thrift/protocol/TBinaryProtocol.java
index 263a818e5..99c3e9302 100644
--- a/lib/java/src/main/java/org/apache/thrift/protocol/TBinaryProtocol.java
+++ b/lib/java/src/main/java/org/apache/thrift/protocol/TBinaryProtocol.java
@@ -553,6 +553,7 @@ public class TBinaryProtocol extends TProtocol {
throw new TTransportException(TTransportException.UNKNOWN, "unrecognized type code");
}
}
+
// -----------------------------------------------------------------
// Additional methods to improve performance.
diff --git a/lib/java/src/main/java/org/apache/thrift/protocol/TCompactProtocol.java b/lib/java/src/main/java/org/apache/thrift/protocol/TCompactProtocol.java
index b522956df..abb5cca31 100644
--- a/lib/java/src/main/java/org/apache/thrift/protocol/TCompactProtocol.java
+++ b/lib/java/src/main/java/org/apache/thrift/protocol/TCompactProtocol.java
@@ -940,6 +940,7 @@ public class TCompactProtocol extends TProtocol {
throw new TTransportException(TTransportException.UNKNOWN, "unrecognized type code");
}
}
+
// -----------------------------------------------------------------
// Additional methods to improve performance.
diff --git a/lib/java/src/main/java/org/apache/thrift/server/TThreadedSelectorServer.java b/lib/java/src/main/java/org/apache/thrift/server/TThreadedSelectorServer.java
index ae3d292d4..86b8dfd23 100644
--- a/lib/java/src/main/java/org/apache/thrift/server/TThreadedSelectorServer.java
+++ b/lib/java/src/main/java/org/apache/thrift/server/TThreadedSelectorServer.java
@@ -65,18 +65,22 @@ public class TThreadedSelectorServer extends AbstractNonblockingServer {
/** The number of threads for selecting on already-accepted connections */
public int selectorThreads = 2;
+
/**
* The size of the executor service (if none is specified) that will handle invocations. This
* may be set to 0, in which case invocations will be handled directly on the selector threads
* (as is in TNonblockingServer)
*/
private int workerThreads = 5;
+
/** Time to wait for server to stop gracefully */
private int stopTimeoutVal = 60;
private TimeUnit stopTimeoutUnit = TimeUnit.SECONDS;
+
/** The ExecutorService for handling dispatched requests */
private ExecutorService executorService = null;
+
/**
* The size of the blocking queue per selector thread for passing accepted connections to the
* selector thread
diff --git a/lib/java/src/main/java/org/apache/thrift/transport/TIOStreamTransport.java b/lib/java/src/main/java/org/apache/thrift/transport/TIOStreamTransport.java
index af745b8b5..44dd2b0ff 100644
--- a/lib/java/src/main/java/org/apache/thrift/transport/TIOStreamTransport.java
+++ b/lib/java/src/main/java/org/apache/thrift/transport/TIOStreamTransport.java
@@ -68,6 +68,7 @@ public class TIOStreamTransport extends TEndpointTransport {
super(config);
inputStream_ = is;
}
+
/**
* Input stream constructor, constructs an input only transport.
*