You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@systemds.apache.org by ar...@apache.org on 2023/06/08 09:25:24 UTC

[systemds] branch main updated: [MINOR] Add missing knobs to the config XML template

This is an automated email from the ASF dual-hosted git repository.

arnabp20 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/systemds.git


The following commit(s) were added to refs/heads/main by this push:
     new 1fb8c5e680 [MINOR] Add missing knobs to the config XML template
1fb8c5e680 is described below

commit 1fb8c5e680171d4fafa5a42a23be927b5600ccac
Author: Arnab Phani <ph...@gmail.com>
AuthorDate: Thu Jun 8 11:23:01 2023 +0200

    [MINOR] Add missing knobs to the config XML template
---
 conf/SystemDS-config.xml.template                  | 6 ++++++
 src/main/java/org/apache/sysds/conf/DMLConfig.java | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/conf/SystemDS-config.xml.template b/conf/SystemDS-config.xml.template
index 45073c349b..3e119bf439 100644
--- a/conf/SystemDS-config.xml.template
+++ b/conf/SystemDS-config.xml.template
@@ -115,6 +115,9 @@
     <!-- Allocator to use to allocate GPU device memory. Supported values are cuda, unified_memory (default: cuda) -->
     <sysds.gpu.memory.allocator>cuda</sysds.gpu.memory.allocator>
 
+    <!-- If rule-based operator placement for GPU enabled -->
+    <sysds.gpu.place.rulebased>false</sysds.gpu.place.rulebased>
+
     <!-- enables disk spilling for lineage cache -->
     <sysds.lineage.cachespill>true</sysds.lineage.cachespill>
 
@@ -148,4 +151,7 @@
     <!-- Asynchronously trigger broadcast (CP intermediate) -->
     <sysds.async.broadcast>false</sysds.async.broadcast>
 
+    <!-- Compile-time synchronous/asynchronous checkpoint placement -->
+    <sysds.async.checkpoint>false</sysds.async.checkpoint>
+
 </root>
diff --git a/src/main/java/org/apache/sysds/conf/DMLConfig.java b/src/main/java/org/apache/sysds/conf/DMLConfig.java
index 1b9cf2cc7d..878b1f74d1 100644
--- a/src/main/java/org/apache/sysds/conf/DMLConfig.java
+++ b/src/main/java/org/apache/sysds/conf/DMLConfig.java
@@ -132,7 +132,7 @@ public class DMLConfig
 	/** Asynchronous triggering of Spark OPs and operator placement **/
 	public static final String ASYNC_SPARK_PREFETCH = "sysds.async.prefetch";  // boolean: enable asynchronous prefetching spark intermediates
 	public static final String ASYNC_SPARK_BROADCAST = "sysds.async.broadcast";  // boolean: enable asynchronous broadcasting CP intermediates
-	public static final String ASYNC_SPARK_CHECKPOINT = "sysds.async.checkpoint";  // boolean: enable asynchronous persisting of Spark intermediates
+	public static final String ASYNC_SPARK_CHECKPOINT = "sysds.async.checkpoint";  // boolean: enable compile-time persisting of Spark intermediates
 	//internal config
 	public static final String DEFAULT_SHARED_DIR_PERMISSION = "777"; //for local fs and DFS