You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2023/02/08 15:08:50 UTC
[GitHub] [maven] cstamas opened a new pull request, #989: [MNG-7677] Maven slowness addressed
cstamas opened a new pull request, #989:
URL: https://github.com/apache/maven/pull/989
The change is effectively in resolver 1.9.5, but there are other "low hanging fruits" like delegate created on a "hot method".
---
https://issues.apache.org/jira/browse/MNG-7677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #989: [MNG-7677] Maven slowness addressed
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #989:
URL: https://github.com/apache/maven/pull/989#issuecomment-1436991042
> So this need to be a singleton?
I'd rather say: given this class is stateless, it CAN be singleton/shared/reused, instead to be re-instantiated for each call of this "hot" method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #989: [MNG-7677] Maven slowness addressed
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #989:
URL: https://github.com/apache/maven/pull/989#issuecomment-1432039834
After https://github.com/apache/maven-resolver/pull/245 merged (and deployed by CI), restarted all the CI jobs on this PR, and they are expected to pass OK, as wrote above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #989: [MNG-7677] Maven slowness addressed
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #989:
URL: https://github.com/apache/maven/pull/989#issuecomment-1431663397
This PR will pass once https://github.com/apache/maven-resolver/pull/245 is merged, built and deployed by Jenkins, and artifacts picked up by this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #989: [MNG-7677] Maven slowness addressed
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #989:
URL: https://github.com/apache/maven/pull/989#issuecomment-1436992656
> > So this need to be a singleton?
>
> I'd rather say: given this class is stateless, it CAN be singleton/shared/reused, instead to be re-instantiated for each call of this "hot" method.
I see, makes sense. No reason to create new objects all the time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas merged pull request #989: [MNG-7677] Maven slowness improvement
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #989:
URL: https://github.com/apache/maven/pull/989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #989: [MNG-7677] Maven slowness addressed
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #989:
URL: https://github.com/apache/maven/pull/989#issuecomment-1436979054
So this need to be a singleton?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org