You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by hqstevenson <gi...@git.apache.org> on 2016/09/21 21:46:08 UTC
[GitHub] activemq-artemis pull request #789: ARTEMIS-737 - added JUnit rules for Arte...
GitHub user hqstevenson opened a pull request:
https://github.com/apache/activemq-artemis/pull/789
ARTEMIS-737 - added JUnit rules for Artemis servers and clients
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hqstevenson/activemq-artemis ARTEMIS-737
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/789.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #789
----
commit c79d00b78c23f55af88c94507c0a5ec8325cf893
Author: Quinn Stevenson <qu...@pronoia-solutions.com>
Date: 2016-09-21T21:45:05Z
ARTEMIS-737 - added JUnit rules for Artemis servers and clients
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #789: ARTEMIS-737 - added JUnit rules for Artemis ser...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/789
@hqstevenson I was looking more for a single example on how to use your annotations. Something we could add a chapter within the documentation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #789: ARTEMIS-737 - added JUnit rules for Artemis ser...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/789
@hqstevenson I didn't mean an actual example.. just how someone would use this into their application.
It looks great.. will merge this soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #789: ARTEMIS-737 - added JUnit rules for Artemis ser...
Posted by hqstevenson <gi...@git.apache.org>.
Github user hqstevenson commented on the issue:
https://github.com/apache/activemq-artemis/pull/789
I fixed the check style issues, and I also added constructors to the EmbeddedXXXResource rules to allow configuring the servers with configuration files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #789: ARTEMIS-737 - added JUnit rules for Artemis ser...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/789
@hqstevenson I merged it with an extra commit, and removed the example.. and added a doc chapter...Please take a look... Feel free to change anything with another PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #789: ARTEMIS-737 - added JUnit rules for Artemis ser...
Posted by hqstevenson <gi...@git.apache.org>.
Github user hqstevenson commented on the issue:
https://github.com/apache/activemq-artemis/pull/789
I just realized I didn't finish the javadoc for the XXXResource classes. I intended to have basic usage information in the javadoc for each class. I'll get that added and update the PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #789: ARTEMIS-737 - added JUnit rules for Artemis ser...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/789
@hqstevenson are you getting notifications for these questions? either here or dev-list
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #789: ARTEMIS-737 - added JUnit rules for Artemis ser...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/789
I guess this is intended for users to use on their tests?
What was the intention, to refactor Artemis' testsuite, or to provide rules for users running their own tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #789: ARTEMIS-737 - added JUnit rules for Artemis ser...
Posted by johnament <gi...@git.apache.org>.
Github user johnament commented on the issue:
https://github.com/apache/activemq-artemis/pull/789
@clebertsuconic agreed. This does look like an awesome idea though for end users trying to test with messaging systems.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #789: ARTEMIS-737 - added JUnit rules for Artemis ser...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/789
@hqstevenson the idea here is to provide final users the capability of running junit tests with a messaging server, right?
It would be nice to have at least an example on how to do this.. can you add at least one test as an example?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #789: ARTEMIS-737 - added JUnit rules for Artemis ser...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/789
This looks a great idea...
however.. there's no docs on how to use this. it would warrant a chapter on the user-docs..
and maybe examples on how to run tests with it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #789: ARTEMIS-737 - added JUnit rules for Artemis ser...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/789
I think it would also be good to have a clear explanation of why this approach is superior to the approach already adopted in the test-suite.
Additional questions:
1. What expectation is there to adopt this style of testing? Should all new tests use this style?
2. Do you plan on converting all existing test-cases to this style? If not, I'd be concerned with having 2 methods of doing the same thing introducing confusion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #789: ARTEMIS-737 - added JUnit rules for Arte...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/789
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #789: ARTEMIS-737 - added JUnit rules for Artemis ser...
Posted by hqstevenson <gi...@git.apache.org>.
Github user hqstevenson commented on the issue:
https://github.com/apache/activemq-artemis/pull/789
I'd be happy to add an example, but I'm not sure exactly what you're looking for. All of the unit tests show the basics of how you embed a sever into your test, and how you use the server afterwards.
Is there a specific type of test you'd like to see?
BTW - once this is released, I'm going to contribute a "example-camel-artemis" to the Camel project - that will show how to use the embedded resources with Camel.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---