You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "Larry McCay (JIRA)" <ji...@apache.org> on 2018/09/21 23:49:00 UTC
[jira] [Comment Edited] (KNOX-1442) Enable forbiddenapis for static
build checking
[ https://issues.apache.org/jira/browse/KNOX-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16624326#comment-16624326 ]
Larry McCay edited comment on KNOX-1442 at 9/21/18 11:48 PM:
-------------------------------------------------------------
[~risdenk] - thanks for this patch as well.
I'm glad that these are separated too - just in case one needs to be reverted.
The thing about such large patches with sort of minor fixes, is that they can make backports really difficult.
I can see the forbidden apis themselves but replacing explicit imports with wildcard imports probably shouldn't be done.
Personally, I don't care for wildcard imports even though they seem to be en vogue again for certain things.
I assume that these changes are also not part of the forbidden apis report?
Can we discard those import changes?
Of course there may end up being unused imports as a result that would need to be removed.
Then we could use an example and instructions for this as well so we know what to look for and how to deal with them.
was (Author: lmccay):
[~risdenk] - thanks for this patch as well.
I'm glad that these are separated too - just in case one needs to be reverted.
The thing about such large patches with sort of minor fixes, is that they can make backports really difficult.
I can see the forbidden apis themselves but replacing explicit imports with wildcard imports probably shouldn't be done.
Personally, I don't care for wildcard imports even though they seem to be en vogue again for certain things.
I assume that these changes are also not part of the forbidden apis report?
Can we discard those import changes?
Of course there may end up being unused imports as a result that would need to be removed.
> Enable forbiddenapis for static build checking
> ----------------------------------------------
>
> Key: KNOX-1442
> URL: https://issues.apache.org/jira/browse/KNOX-1442
> Project: Apache Knox
> Issue Type: Improvement
> Components: Build
> Reporter: Kevin Risden
> Assignee: Kevin Risden
> Priority: Major
> Fix For: 1.2.0
>
> Attachments: KNOX-1442.patch
>
>
> Split out from KNOX-1284 specifically for forbiddenapis.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)