You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/04 17:52:12 UTC
[GitHub] [incubator-nuttx] pkarashchenko opened a new pull request, #6789: drivers/net: make sure that net driver d_buf is 16-bit aligned
pkarashchenko opened a new pull request, #6789:
URL: https://github.com/apache/incubator-nuttx/pull/6789
## Summary
- make sure that net driver `d_buf` is 16-bit aligned
- fix buffer selection multi-instance netdev drivers
- add missing `FAR` in multiple palces
- perform some renaming in w5500 driver to remove `sk_` (skeleton) prefix
## Impact
Should be none for working cases
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #6789: drivers/net: make sure that net driver d_buf is 16-bit aligned
Posted by GitBox <gi...@apache.org>.
davids5 commented on PR #6789:
URL: https://github.com/apache/incubator-nuttx/pull/6789#issuecomment-1206285930
> > @pkarashchenko Why the name change from ETH_HDR to BUF?
>
> Just to unify across the available variants. I can get back that macro
For me it adds context at the point of use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #6789: drivers/net: make sure that net driver d_buf is 16-bit aligned
Posted by GitBox <gi...@apache.org>.
davids5 commented on PR #6789:
URL: https://github.com/apache/incubator-nuttx/pull/6789#issuecomment-1206277578
@pkarashchenko Why the name change from ETH_HDR to BUF?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #6789: drivers/net: make sure that net driver d_buf is 16-bit aligned
Posted by GitBox <gi...@apache.org>.
davids5 commented on PR #6789:
URL: https://github.com/apache/incubator-nuttx/pull/6789#issuecomment-1206289622
> > > > @pkarashchenko Why the name change from ETH_HDR to BUF?
> > >
> > >
> > > Just to unify across the available variants. I can get back that macro
> >
> >
> > For me it adds context at the point of use.
>
> I can rename other 6 places to be ETH_HDR. What do you think?
I would since all the files are being touched. I will leave it up to you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6789: drivers/net: make sure that net driver d_buf is 16-bit aligned
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #6789:
URL: https://github.com/apache/incubator-nuttx/pull/6789#issuecomment-1206287148
> > > @pkarashchenko Why the name change from ETH_HDR to BUF?
> >
> > Just to unify across the available variants. I can get back that macro
>
> For me it adds context at the point of use.
I can rename other 6 places to be ETH_HDR. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6789: drivers/net: make sure that net driver d_buf is 16-bit aligned
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #6789:
URL: https://github.com/apache/incubator-nuttx/pull/6789#issuecomment-1206284265
> @pkarashchenko Why the name change from ETH_HDR to BUF?
Just to unify across the available variants. I can get back that macro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6789: drivers/net: make sure that net driver d_buf is 16-bit aligned
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6789:
URL: https://github.com/apache/incubator-nuttx/pull/6789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6789: drivers/net: make sure that net driver d_buf is 16-bit aligned
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #6789:
URL: https://github.com/apache/incubator-nuttx/pull/6789#issuecomment-1206326557
> > > > > @pkarashchenko Why the name change from ETH_HDR to BUF?
> > > >
> > > >
> > > > Just to unify across the available variants. I can get back that macro
> > >
> > >
> > > For me it adds context at the point of use.
> >
> >
> > I can rename other 6 places to be ETH_HDR. What do you think?
>
> I would since all the files are being touched. I will leave it up to you
I've re-checked all over the code and majority of cases are
- `#define BUF ((struct eth_hdr_s *)priv->c_dev.d_buf)`
- `#define ETHBUF ((struct eth_hdr_s *)priv->eth_dev.d_buf)`
and `#define BUF` is a dominant use case, so let's keep `BUF` for w5500 as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org