You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Juhwan Kim (JIRA)" <ji...@apache.org> on 2019/07/09 05:27:00 UTC

[jira] [Commented] (CALCITE-3183) Trimming method for Filter rel uses wrong traitSet

    [ https://issues.apache.org/jira/browse/CALCITE-3183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16880941#comment-16880941 ] 

Juhwan Kim commented on CALCITE-3183:
-------------------------------------

As [~zabetak] suggested, I thought using input's trait set could be a solution for this. However, adding a factory method that includes correlating variable seems to be more fundamental solution. Posted a pull request for this.

> Trimming method for Filter rel uses wrong traitSet 
> ---------------------------------------------------
>
>                 Key: CALCITE-3183
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3183
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Juhwan Kim
>            Assignee: Juhwan Kim
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> It seems like there is a bug here: https://github.com/apache/calcite/blob/e8d598a434e8dbadaf756f8c57c748f4d7e16fdf/core/src/main/java/org/apache/calcite/sql2rel/RelFieldTrimmer.java#L487.
> Unlike other trimming methods, filter trim function copies the current filter rel and directly pushes it to the builder instead of calling factory method for filter rel. The problem with the current code is that it uses the same traitSet even though it would no longer be valid after trimming its input. For example, fields in collation might have been updated after trimming. We should reflect this change when creating a new rel.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)