You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/19 11:13:35 UTC
[GitHub] [airflow] potiuk opened a new pull request, #25155: Update description of branch creation to include the new Breeze
potiuk opened a new pull request, #25155:
URL: https://github.com/apache/airflow/pull/25155
The new Breeze has a different place where default branch and
constraints branch are kept.
When we create a new "release" branch we should update it here
as well as in the bash legacy breeze (until the bash breeze has
stil some zombies around)
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #25155: Update description of branch creation to include the new Breeze
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #25155:
URL: https://github.com/apache/airflow/pull/25155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25155: Update description of branch creation to include the new Breeze
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25155:
URL: https://github.com/apache/airflow/pull/25155#issuecomment-1189522454
We should merge it before 2.4 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25155: Update description of branch creation to include the new Breeze
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25155:
URL: https://github.com/apache/airflow/pull/25155#issuecomment-1188924713
I noticed the description of branch creation was not updated with the new Breeze while I was explaining the "default branch" concept to @jedcunningham in https://github.com/apache/airflow/pull/25056#discussion_r924361243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #25155: Update description of branch creation to include the new Breeze
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on code in PR #25155:
URL: https://github.com/apache/airflow/pull/25155#discussion_r924944529
##########
dev/README_RELEASE_AIRFLOW.md:
##########
@@ -375,6 +377,22 @@ values for comparison and regexp):
AIRFLOW_BRANCH_FOR_PYPI_PRELOADING="vX-Y-stable"
```
+#### In the new breeze (to be removed when bash breeze is entirely gone)
Review Comment:
```suggestion
#### In the new breeze
```
I mean, the heading will go away, but that's it, right?
##########
dev/README_RELEASE_AIRFLOW.md:
##########
@@ -353,6 +353,8 @@ Run script to re-tag images from the ``main`` branch to the ``vX-Y-test`` branc
### Update default branches
+#### In the legacy, bash breeze (to be removed when the breeze is entirely gone)
Review Comment:
```suggestion
#### In the legacy, bash breeze (to be removed when the bash breeze is entirely gone)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org