You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/07/24 05:16:25 UTC

[GitHub] [spark] HyukjinKwon opened a new pull request, #42120: [SPARK-44509][PYTHON][CONNECT] Add job cancellation API set in Spark Connect Python client

HyukjinKwon opened a new pull request, #42120:
URL: https://github.com/apache/spark/pull/42120

   ### What changes were proposed in this pull request?
   
   This PR proposes the Python implementations for https://github.com/apache/spark/pull/42009.
   
   ### Why are the changes needed?
   
   For the feature parity, and better control of query cancelation in Spark Connect
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. New Apis in Spark Connect Python client:
   
   ```
   SparkSession.addTag
   SparkSession.removeTag
   SparkSession.getTags
   SparkSession.clearTags
   SparkSession.interruptTag
   SparkSession.interruptOperation
   ```
   
   ### How was this patch tested?
   
   Unittests were added, and manually tested too.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #42120: [SPARK-44509][PYTHON][CONNECT] Add job cancellation API set in Spark Connect Python client

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42120:
URL: https://github.com/apache/spark/pull/42120#issuecomment-1648906956

   Merged to master and branch-3.5.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42120: [SPARK-44509][PYTHON][CONNECT] Add job cancellation API set in Spark Connect Python client

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #42120:
URL: https://github.com/apache/spark/pull/42120#discussion_r1272933655


##########
python/pyspark/sql/connect/client/core.py:
##########
@@ -574,6 +576,8 @@ def __init__(
             the $USER environment. Defining the user ID as part of the connection string
             takes precedence.
         """
+        self.thread_local = threading.local()

Review Comment:
   BTW, there is difference here. Python's threadlocal isn't inheritable (and there's no such implementation in Python). So we should somehow workaround this ...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #42120: [SPARK-44509][PYTHON][CONNECT] Add job cancellation API set in Spark Connect Python client

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #42120: [SPARK-44509][PYTHON][CONNECT] Add job cancellation API set in Spark Connect Python client
URL: https://github.com/apache/spark/pull/42120


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org