[jira] Commented: (TUSCANY-2897) requestConnection and responseConnection in JMSBinding model should be QNames not Strings

["Greg Dritschler (JIRA)" <de...@tuscany.apache.org>]

    [ https://issues.apache.org/jira/browse/TUSCANY-2897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677731#action_12677731 ] 

Greg Dritschler commented on TUSCANY-2897:
------------------------------------------

I am attaching a patch for this problem.

A binding model object doesn't naturally have a field to hold the definition namespace (unlike other definition elements like Intent or PolicySet).  So I had to invent an interface DefinitionElement which the binding can implement and which the SCADefinitionProcessor can use to set the definition namespace on a binding object.

I made a minor correction to the definitions.xml file in the jms-definitions itest.  The binding definition erroneously included a namespace prefix in the binding name.  Prefixes are only used in references to the definition, not in the definition itself.

I also made a change to the resolution process to make it more consistent with how other definition elements are resolved.  JMSBindingProcessor was looking directly in the global definitions resolver for the binding definition.  This is not necessary.  SCADefinitionProcessor puts the definition objects in the composite's resolver so they can be resolved normally.  The only issue I encountered with this is that revision 743796 added an equals() method to JMSBinding which compares all of the fields for equality.  The standard model resolver lookup I am using depends on equals() looking at key fields only.  I have tried to accommodate this as best I can.  I think the requirement for comparing all of the fields needs to be re-examined.





> requestConnection and responseConnection in JMSBinding model should be QNames not Strings
> -----------------------------------------------------------------------------------------
>
>                 Key: TUSCANY-2897
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-2897
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA JMS Binding Extension
>            Reporter: Greg Dritschler
>            Priority: Minor
>         Attachments: tuscany-2897.patch
>
>
> In the JMSBinding model the requestConnection and responseConnection attributes are treated as Strings.  According to the schema they are supposed to be QNames (where the namespace is used to locate the definition document and the local part is the binding name).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.