You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/12/03 01:11:28 UTC

[kudu-CR] raft consensus-itest: add a test for a potential deadlock 

Hello David Ribeiro Alves,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/5341

to review the following change.

Change subject: raft_consensus-itest: add a test for a potential deadlock
......................................................................

raft_consensus-itest: add a test for a potential deadlock

This adds a test case where multiple pending operations have lock
dependencies on each other, and the replica needs to replace one that's
stuck waiting in the queue before it can make progress.

This catches a bug found in a revision of
https://gerrit.cloudera.org/#/c/5294/ which wasn't covered by existing
test cases.

Change-Id: Ie1143045780886958e45f667b1877b4e34e8b03e
---
M src/kudu/integration-tests/raft_consensus-itest.cc
1 file changed, 72 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/5341/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie1143045780886958e45f667b1877b4e34e8b03e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>

[kudu-CR] raft consensus-itest: add a test for a potential deadlock

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.

Change subject: raft_consensus-itest: add a test for a potential deadlock
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1143045780886958e45f667b1877b4e34e8b03e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] raft consensus-itest: add a test for a potential deadlock

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged.

Change subject: raft_consensus-itest: add a test for a potential deadlock
......................................................................


raft_consensus-itest: add a test for a potential deadlock

This adds a test case where multiple pending operations have lock
dependencies on each other, and the replica needs to replace one that's
stuck waiting in the queue before it can make progress.

This catches a bug found in a revision of
https://gerrit.cloudera.org/#/c/5294/ which wasn't covered by existing
test cases.

Change-Id: Ie1143045780886958e45f667b1877b4e34e8b03e
Reviewed-on: http://gerrit.cloudera.org:8080/5341
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves <dr...@apache.org>
---
M src/kudu/integration-tests/raft_consensus-itest.cc
1 file changed, 72 insertions(+), 2 deletions(-)

Approvals:
  David Ribeiro Alves: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5341
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1143045780886958e45f667b1877b4e34e8b03e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins