You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/12/11 22:56:31 UTC

[GitHub] [mynewt-nimble] ccollins476ad commented on issue #697: Added extra argument to sync and reset collback to simplify building C++ Wrapper

ccollins476ad commented on issue #697: Added extra argument to sync and reset collback to simplify building C++ Wrapper
URL: https://github.com/apache/mynewt-nimble/pull/697#issuecomment-564770569
 
 
   > But it also is not good to have lots of functions like this:
   > 
   > ```c
   > ...
   >     ble_hs_reset_fn *reset_cb;
   > 
   >     ble_hs_reset_extra_fn *reset_extra_cb;
   >     void *reset_extra_cb_arg;
   > 
   >     ble_hs_sync_fn *sync_cb;
   > 
   >     ble_hs_sync_extra_fn *sync_extra_cb;
   >     void *sync_extra_cb_arg;
   > ...
   > ```
   
   You may have a good point here (I didn't understand the point), but it is irrelevant.  We have existing users and we simply cannot break backwards compatibility without a transition period.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services