You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "lucasssvaz (via GitHub)" <gi...@apache.org> on 2023/02/23 16:18:19 UTC
[GitHub] [nuttx-apps] lucasssvaz opened a new pull request, #1596: benchmarks/coremark: Fix recompilation bug
lucasssvaz opened a new pull request, #1596:
URL: https://github.com/apache/nuttx-apps/pull/1596
## Summary
The Coremark Makefile is missing the `DEPPATH` setup. This causes the files to not be recompiled when changing Kconfig options.
Thanks @tmedicci for the help!
## Impact
Proper behavior of the Coremark compilation process.
## Testing
Tested using `esp32-devkitc:coremark`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #1596: benchmarks/coremark: Fix recompilation bug
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #1596:
URL: https://github.com/apache/nuttx-apps/pull/1596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #1596: benchmarks/coremark: Fix recompilation bug
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #1596:
URL: https://github.com/apache/nuttx-apps/pull/1596#discussion_r1116041787
##########
benchmarks/coremark/Kconfig:
##########
@@ -26,6 +26,10 @@ config COREMARK_STACKSIZE
int "Coremark task stack size"
default 4096
+config COREMARK_MEM_LOCATION
+ string "Coremark memory location string"
+ default "Defined by the NuttX configuration"
Review Comment:
Please use TABs in Kconfig
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org