[jira] [Updated] (HADOOP-10942) Globbing optimizations and regression fix

["Daryn Sharp (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-10942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daryn Sharp updated HADOOP-10942:
---------------------------------

    Attachment: HADOOP-10942.patch

Existing tests in {{TestGlobPaths}} were designed to catch the regressed bug.  However permission checking was disabled and the priviledged vs unpriviledged fs management was buggy.

The existing logic made re-fixing that bug not straightforward.  I reverted it back to be more inline with 0.23's implementation, while retaining the additional rpc reducing optimizations added in 2.x.

I separated the logic into multiple methods, removed funky code for using/removing a root placeholder status by only using when necessary, doing a simple immediate file status if the path contains no globs, etc.

> Globbing optimizations and regression fix
> -----------------------------------------
>
>                 Key: HADOOP-10942
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10942
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 3.0.0, 2.1.0-beta
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>            Priority: Critical
>         Attachments: HADOOP-10942.patch
>
>
> When globbing was commonized to support both filesystem and filecontext, it regressed a fix that prevents an intermediate glob that matches a file from throwing a confusing permissions exception.  The hdfs traverse check requires the exec bit which a file does not have.
> Additional optimizations to reduce rpcs actually increases them if directories contain 1 item.



--
This message was sent by Atlassian JIRA
(v6.2#6252)