You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jobs@airflow.apache.org by GitBox <gi...@apache.org> on 2025/08/20 00:14:24 UTC
[GH] (airflow/backport-462ce9a-v3-0-test): Workflow run "Tests AMD" failed!
The GitHub Actions job "Tests AMD" on airflow.git/backport-462ce9a-v3-0-test has failed.
Run started by GitHub user potiuk (triggered by potiuk).
Head commit for run:
8abce7ce001925022912d067cbcc27e252ba9f7a / Vic Wen <99...@users.noreply.github.com>
[v3-0-test] Fix module loading in logging config (#54555)
* fix(logging): fix module loading by using `import_module()`
- Replace `import_string()` with `import_module()` in `load_logging_config()`
- Fix issue where simple module paths like `log_config.LOGGING_CONFIG` failed
- Add `importlib` import inside function to avoid circular imports
* test(logging): add tests for logging config module path handling
- Add parametrized test for simple and nested module paths
- Add test for graceful fallback when remote logging vars are missing
- Create helper method to reduce test code duplication
- Test both log_config.LOGGING_CONFIG and nested.module.LOGGING_CONFIG scenarios
Ensures logging config works with various module path structures
* fix(logging): fix module loading by using `import_module()`
- Replace `import_string()` with `import_module()` in `load_logging_config()`
- Fix issue where simple module paths like `log_config.LOGGING_CONFIG` failed
- Add `importlib` import inside function to avoid circular imports
* test(logging): add tests for logging config module path handling
- Add parametrized test for simple and nested module paths
- Add test for graceful fallback when remote logging vars are missing
- Create helper method to reduce test code duplication
- Test both log_config.LOGGING_CONFIG and nested.module.LOGGING_CONFIG scenarios
Ensures logging config works with various module path structures
* fix(logging): fix module loading by using `import_module()`
- Replace `import_string()` with `import_module()` in `load_logging_config()`
- Fix issue where simple module paths like `log_config.LOGGING_CONFIG` failed
- Add `importlib` import inside function to avoid circular imports
* test(logging): add tests for logging config module path handling
- Add parametrized test for simple and nested module paths
- Add test for graceful fallback when remote logging vars are missing
- Create helper method to reduce test code duplication
- Test both log_config.LOGGING_CONFIG and nested.module.LOGGING_CONFIG scenarios
Ensures logging config works with various module path structures
* refactor(logging): move `import_module` to the top level
* test(logging): optimize test constants to reduce code duplication
Replace `SETTINGS_FILE_NESTED_MODULE` replicate part with string replacement from `SETTINGS_FILE_SIMPLE_MODULE`
* test(logging): use shared helper method for logging config validation
Replace manual assertions with `self._verify_basic_logging_config` in fallback test to ensure consistent validation across all logging config tests.
* refactor(logging_config): simplify, improve test config vars
- Remove redundant `SETTINGS_FILE_NESTED_MODULE`
- Rename `SETTINGS_FILE_SIMPLE_MODULE` to `SETTINGS_FILE_WITH_REMOTE_VARS`
* refactor(logging): imporve & simplify logging testing file
1. remove `SETTING_FILE_NO_REMOTE_VARS` bcz redundant var
2. add return typo with `_verify_basic_logging_config`
3. add unittest.mock `call`
(cherry picked from commit 462ce9a674690e3157e68f70381008947f33418d)
Co-authored-by: Vic Wen <99...@users.noreply.github.com>
Report URL: https://github.com/apache/airflow/actions/runs/17084451465
With regards,
GitHub Actions via GitBox
---------------------------------------------------------------------
To unsubscribe, e-mail: jobs-unsubscribe@airflow.apache.org
For additional commands, e-mail: jobs-help@airflow.apache.org