You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/11 10:43:19 UTC
[GitHub] [shardingsphere] menghaoranss opened a new pull request #5532: Improve unit test coverage of sharding-orchestration#apollo
menghaoranss opened a new pull request #5532:
URL: https://github.com/apache/shardingsphere/pull/5532
For #5489
Changes proposed in this pull request:
- upgrade the unit test coverage of sharding-orchestration-center-apollo to 90%+
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #5532: Improve unit test coverage of sharding-orchestration#apollo
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #5532:
URL: https://github.com/apache/shardingsphere/pull/5532#issuecomment-626653093
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5532?src=pr&el=h1) Report
> Merging [#5532](https://codecov.io/gh/apache/shardingsphere/pull/5532?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/d51168f38fab8959f8c9aae36eb05bc61ae76fa7&el=desc) will **increase** coverage by `0.22%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/5532?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5532 +/- ##
============================================
+ Coverage 55.08% 55.30% +0.22%
Complexity 423 423
============================================
Files 1145 1145
Lines 20118 20115 -3
Branches 3669 3669
============================================
+ Hits 11081 11124 +43
+ Misses 8346 8300 -46
Partials 691 691
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5532?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ration/center/instance/ApolloCenterRepository.java](https://codecov.io/gh/apache/shardingsphere/pull/5532/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci1hcG9sbG8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY2VudGVyL2luc3RhbmNlL0Fwb2xsb0NlbnRlclJlcG9zaXRvcnkuamF2YQ==) | `88.88% <100.00%> (+27.35%)` | `0.00 <0.00> (ø)` | |
| [.../center/instance/wrapper/ApolloOpenApiWrapper.java](https://codecov.io/gh/apache/shardingsphere/pull/5532/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci1hcG9sbG8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY2VudGVyL2luc3RhbmNlL3dyYXBwZXIvQXBvbGxvT3BlbkFwaVdyYXBwZXIuamF2YQ==) | `100.00% <0.00%> (+100.00%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5532?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5532?src=pr&el=footer). Last update [d51168f...299aab3](https://codecov.io/gh/apache/shardingsphere/pull/5532?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #5532: Improve unit test coverage of sharding-orchestration#apollo
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5532:
URL: https://github.com/apache/shardingsphere/pull/5532#issuecomment-626654987
## Pull Request Test Coverage Report for [Build 11600](https://coveralls.io/builds/30697168)
* **1** of **1** **(100.0%)** changed or added relevant line in **1** file are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.2%**) to **58.807%**
---
| Totals | [](https://coveralls.io/builds/30697168) |
| :-- | --: |
| Change from base [Build 11599](https://coveralls.io/builds/30696196): | 0.2% |
| Covered Lines: | 11829 |
| Relevant Lines: | 20115 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org