You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2019/06/18 08:08:36 UTC
[kudu-CR] KUDU-2867. Optimize delta timestamp decoding
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13667
Change subject: KUDU-2867. Optimize delta timestamp decoding
......................................................................
KUDU-2867. Optimize delta timestamp decoding
When using hybrid clock, all timestamps require a full 8-byte varint to
be encoded. So, we can inline this fast path in Timestamp::DecodeFrom to
avoid the more complicated/lengthy GetMemcmpableVarint code.
Change-Id: I1665e0aaed874cf4d47ecf5e467246a9505b0bd1
---
M src/kudu/common/timestamp.cc
M src/kudu/common/timestamp.h
2 files changed, 19 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/13667/1
--
To view, visit http://gerrit.cloudera.org:8080/13667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1665e0aaed874cf4d47ecf5e467246a9505b0bd1
Gerrit-Change-Number: 13667
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-2867. Optimize delta timestamp decoding
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13667 )
Change subject: KUDU-2867. Optimize delta timestamp decoding
......................................................................
KUDU-2867. Optimize delta timestamp decoding
When using hybrid clock, all timestamps require a full 8-byte varint to
be encoded. So, we can inline this fast path in Timestamp::DecodeFrom to
avoid the more complicated/lengthy GetMemcmpableVarint code.
Change-Id: I1665e0aaed874cf4d47ecf5e467246a9505b0bd1
Reviewed-on: http://gerrit.cloudera.org:8080/13667
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/common/timestamp.cc
M src/kudu/common/timestamp.h
2 files changed, 20 insertions(+), 6 deletions(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, but someone else must approve
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1665e0aaed874cf4d47ecf5e467246a9505b0bd1
Gerrit-Change-Number: 13667
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-2867. Optimize delta timestamp decoding
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13667
to look at the new patch set (#2).
Change subject: KUDU-2867. Optimize delta timestamp decoding
......................................................................
KUDU-2867. Optimize delta timestamp decoding
When using hybrid clock, all timestamps require a full 8-byte varint to
be encoded. So, we can inline this fast path in Timestamp::DecodeFrom to
avoid the more complicated/lengthy GetMemcmpableVarint code.
Change-Id: I1665e0aaed874cf4d47ecf5e467246a9505b0bd1
---
M src/kudu/common/timestamp.cc
M src/kudu/common/timestamp.h
2 files changed, 20 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/13667/2
--
To view, visit http://gerrit.cloudera.org:8080/13667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1665e0aaed874cf4d47ecf5e467246a9505b0bd1
Gerrit-Change-Number: 13667
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2867. Optimize delta timestamp decoding
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13667 )
Change subject: KUDU-2867. Optimize delta timestamp decoding
......................................................................
Patch Set 1: Code-Review+1
IWYU failed
--
To view, visit http://gerrit.cloudera.org:8080/13667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1665e0aaed874cf4d47ecf5e467246a9505b0bd1
Gerrit-Change-Number: 13667
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 18 Jun 2019 12:40:33 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2867. Optimize delta timestamp decoding
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13667 )
Change subject: KUDU-2867. Optimize delta timestamp decoding
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1665e0aaed874cf4d47ecf5e467246a9505b0bd1
Gerrit-Change-Number: 13667
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 26 Jun 2019 23:18:58 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2867. Optimize delta timestamp decoding
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13667 )
Change subject: KUDU-2867. Optimize delta timestamp decoding
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/13667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1665e0aaed874cf4d47ecf5e467246a9505b0bd1
Gerrit-Change-Number: 13667
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 18 Jun 2019 21:12:45 +0000
Gerrit-HasComments: No