You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Kristian Waagan (JIRA)" <ji...@apache.org> on 2010/08/13 09:19:17 UTC

[jira] Created: (DERBY-4770) Files missing svn:eol-style (August 2010)

Files missing svn:eol-style (August 2010)
-----------------------------------------

                 Key: DERBY-4770
                 URL: https://issues.apache.org/jira/browse/DERBY-4770
             Project: Derby
          Issue Type: Bug
          Components: Miscellaneous
    Affects Versions: 10.7.0.0
            Reporter: Kristian Waagan


Some new files have been added without the svn:eol-style property set. These files should have the property set with value "native".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (DERBY-4770) Files missing svn:eol-style (August 2010)

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-4770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan reassigned DERBY-4770:
--------------------------------------

    Assignee: Kristian Waagan

> Files missing svn:eol-style (August 2010)
> -----------------------------------------
>
>                 Key: DERBY-4770
>                 URL: https://issues.apache.org/jira/browse/DERBY-4770
>             Project: Derby
>          Issue Type: Bug
>          Components: Miscellaneous
>    Affects Versions: 10.7.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>         Attachments: derby-4770-1a-eol_style_trunk.diff
>
>
> Some new files have been added without the svn:eol-style property set. These files should have the property set with value "native".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-4770) Files missing svn:eol-style (August 2010)

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-4770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-4770:
-----------------------------------

    Attachment: derby-4770-2a-eol_style_10_6.diff
                derby-4770-3a-eol_style_10_5.diff

Attached the diffs for branches 10.6 and 10.5.
I didn't spot any Java files with the eol-style missing in 10.4.

> Files missing svn:eol-style (August 2010)
> -----------------------------------------
>
>                 Key: DERBY-4770
>                 URL: https://issues.apache.org/jira/browse/DERBY-4770
>             Project: Derby
>          Issue Type: Bug
>          Components: Miscellaneous
>    Affects Versions: 10.7.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.5.3.1, 10.6.1.1, 10.7.0.0
>
>         Attachments: derby-4770-1a-eol_style_trunk.diff, derby-4770-2a-eol_style_10_6.diff, derby-4770-3a-eol_style_10_5.diff
>
>
> Some new files have been added without the svn:eol-style property set. These files should have the property set with value "native".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-4770) Files missing svn:eol-style (August 2010)

Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-4770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898334#action_12898334 ] 

Myrna van Lunteren commented on DERBY-4770:
-------------------------------------------

I think it worthwhile backporting svn-eol-style settings. I'm usually working on windows OS and I've had failing commits because of mixed-eol characters. Of course it can be corrected at that time, but...

> Files missing svn:eol-style (August 2010)
> -----------------------------------------
>
>                 Key: DERBY-4770
>                 URL: https://issues.apache.org/jira/browse/DERBY-4770
>             Project: Derby
>          Issue Type: Bug
>          Components: Miscellaneous
>    Affects Versions: 10.7.0.0
>            Reporter: Kristian Waagan
>         Attachments: derby-4770-1a-eol_style_trunk.diff
>
>
> Some new files have been added without the svn:eol-style property set. These files should have the property set with value "native".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-4770) Files missing svn:eol-style (August 2010)

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-4770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-4770:
-----------------------------------

    Attachment: derby-4770-1a-eol_style_trunk.diff

Attached patch 1a, which sets the svn:eol-style to native for 14 files.
Committed to trunk with revision 985120.

Again, should such changes be backported?


The list of files missing the property was compiled with the following script:
for i in `find java/ -name "*.java"`; do
     svn info $i > /dev/null 2>&1 && ( svn proplist $i | grep svn:eol-style > /dev/null || echo "$i") >> /tmp/missing-eol-ALL.txt 
done

For now I have left other types (non '.java') of files alone.

> Files missing svn:eol-style (August 2010)
> -----------------------------------------
>
>                 Key: DERBY-4770
>                 URL: https://issues.apache.org/jira/browse/DERBY-4770
>             Project: Derby
>          Issue Type: Bug
>          Components: Miscellaneous
>    Affects Versions: 10.7.0.0
>            Reporter: Kristian Waagan
>         Attachments: derby-4770-1a-eol_style_trunk.diff
>
>
> Some new files have been added without the svn:eol-style property set. These files should have the property set with value "native".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (DERBY-4770) Files missing svn:eol-style (August 2010)

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-4770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan closed DERBY-4770.
----------------------------------

    Fix Version/s: 10.5.3.1
                   10.6.1.1
                   10.7.0.0
       Resolution: Fixed

Committed patches 2a and 3a with revisions 993329 and 993330.
Closing the issue.

> Files missing svn:eol-style (August 2010)
> -----------------------------------------
>
>                 Key: DERBY-4770
>                 URL: https://issues.apache.org/jira/browse/DERBY-4770
>             Project: Derby
>          Issue Type: Bug
>          Components: Miscellaneous
>    Affects Versions: 10.7.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.5.3.1, 10.6.1.1, 10.7.0.0
>
>         Attachments: derby-4770-1a-eol_style_trunk.diff, derby-4770-2a-eol_style_10_6.diff, derby-4770-3a-eol_style_10_5.diff
>
>
> Some new files have been added without the svn:eol-style property set. These files should have the property set with value "native".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.