You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "danny0405 (via GitHub)" <gi...@apache.org> on 2023/03/30 04:55:27 UTC

[GitHub] [hudi] danny0405 opened a new pull request, #8323: [HUDI-6005] Auto generate client id for Flink multi writer

danny0405 opened a new pull request, #8323:
URL: https://github.com/apache/hudi/pull/8323

   ### Change Logs
   
   The current flink does not have a good msg notification mechanism from JM to TM tasks. In order to get rid of this, we introduced two kind of fs based messages on the JM:
   
   1. the view_storage_conf file to keep remote fs view storage properties
   2. the ckp_metadata used for pending instants fetching in light-weight way
   
   Both of the two messages work well on single-writer scenario, we just use a fixed name file path for these files/directories. But in multi-writer scenario, writing into same name msg file incurs conflicts, the msg file finally got corrupted and the existing writers can be impacted.
   
   In HUDI-5673, we introduced an option 'write.client.id' for manual conflict resolution, the user needs to config the client id for each of the multi-writers. This is valid but very inconvenient in production practice.
   
   In this patch, we try to auto infer the client id when the job is submitted from the client machine. On start up, each job tries to scramble for a client id first, after the job is running, the coordinator on JM would try to send a heartbeat message for its client id in a fixed time interval(by default 1 minute).
   
   The heartbeat is mainly used for deciding whether the job that holds the client id is still alive, if not, the client id can be recycled and reused.
   
   ### Impact
   
   no impact
   
   ### Risk level (write none, low medium or high below)
   
   none
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, config, or user-facing change_
   
   - _The config description must be updated if new configs are added or the default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
     ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8323: [HUDI-6005] Auto generate client id for Flink multi writer

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8323:
URL: https://github.com/apache/hudi/pull/8323#issuecomment-1489902936

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ebbdbd61ce0c7396371b94b7461f65a266cea7ce",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15983",
       "triggerID" : "ebbdbd61ce0c7396371b94b7461f65a266cea7ce",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ebbdbd61ce0c7396371b94b7461f65a266cea7ce Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15983) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] danny0405 merged pull request #8323: [HUDI-6005] Auto generate client id for Flink multi writer

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #8323:
URL: https://github.com/apache/hudi/pull/8323


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8323: [HUDI-6005] Auto generate client id for Flink multi writer

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8323:
URL: https://github.com/apache/hudi/pull/8323#issuecomment-1489725719

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ebbdbd61ce0c7396371b94b7461f65a266cea7ce",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ebbdbd61ce0c7396371b94b7461f65a266cea7ce",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ebbdbd61ce0c7396371b94b7461f65a266cea7ce UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #8323: [HUDI-6005] Auto generate client id for Flink multi writer

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8323:
URL: https://github.com/apache/hudi/pull/8323#issuecomment-1489730417

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ebbdbd61ce0c7396371b94b7461f65a266cea7ce",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15983",
       "triggerID" : "ebbdbd61ce0c7396371b94b7461f65a266cea7ce",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ebbdbd61ce0c7396371b94b7461f65a266cea7ce Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15983) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org