You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/06 17:36:36 UTC
[GitHub] [camel-quarkus] ppalaga opened a new pull request #857: Fix #787
JSon XStream dataformat support
ppalaga opened a new pull request #857: Fix #787 JSon XStream dataformat support
URL: https://github.com/apache/camel-quarkus/pull/857
Fix #787
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga merged pull request #857: Fix #787 JSon
XStream dataformat support
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #857: Fix #787 JSon XStream dataformat support
URL: https://github.com/apache/camel-quarkus/pull/857
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull
request #857: Fix #787 JSon XStream dataformat support
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #857: Fix #787 JSon XStream dataformat support
URL: https://github.com/apache/camel-quarkus/pull/857#discussion_r389050607
##########
File path: extensions/support/xstream/deployment/src/main/java/org/apache/camel/quarkus/support/xstream/deployment/XStreamSupportProcessor.java
##########
@@ -116,57 +89,71 @@ void process(CombinedIndexBuildItem indexBuildItem,
"com.thoughtworks.xstream.converters.time.ThaiBuddhistDateConverter",
"com.thoughtworks.xstream.converters.time.YearConverter",
"com.thoughtworks.xstream.converters.time.YearMonthConverter",
- "com.thoughtworks.xstream.converters.time.ZonedDateTimeConverter",
"com.thoughtworks.xstream.converters.time.ZoneIdConverter",
- "java.lang.Void",
- "java.lang.Object",
+ "com.thoughtworks.xstream.converters.time.ZonedDateTimeConverter",
+ "com.thoughtworks.xstream.core.ClassLoaderReference",
+ "com.thoughtworks.xstream.core.JVM",
+ "com.thoughtworks.xstream.core.JVM$Test",
+ "com.thoughtworks.xstream.core.util.Base64JavaUtilCodec",
+ "com.thoughtworks.xstream.core.util.CustomObjectOutputStream",
+ "com.thoughtworks.xstream.mapper.AnnotationConfiguration",
+ "com.thoughtworks.xstream.mapper.Mapper",
+ "com.thoughtworks.xstream.mapper.Mapper$Null",
+ "com.thoughtworks.xstream.security.AnyTypePermission",
+ "com.thoughtworks.xstream.security.ArrayTypePermission",
+ "com.thoughtworks.xstream.security.ExplicitTypePermission",
+ "com.thoughtworks.xstream.security.ForbiddenClassException",
+ "com.thoughtworks.xstream.security.InterfaceTypePermission",
+ "com.thoughtworks.xstream.security.NoPermission",
+ "com.thoughtworks.xstream.security.NoTypePermission",
+ "com.thoughtworks.xstream.security.NullPermission",
+ "com.thoughtworks.xstream.security.PrimitiveTypePermission",
+ "com.thoughtworks.xstream.security.ProxyTypePermission",
+ "com.thoughtworks.xstream.security.RegExpTypePermission",
+ "com.thoughtworks.xstream.security.TypeHierarchyPermission",
+ "com.thoughtworks.xstream.security.TypePermission",
+ "com.thoughtworks.xstream.security.WildcardTypePermission",
"java.awt.Color",
- "javax.swing.LookAndFeel",
- "java.sql.Date",
+ "java.awt.Font",
+ "java.awt.font.TextAttribute",
+ "java.io.File",
+ "java.lang.Boolean",
+ "java.lang.Byte",
+ "java.lang.Character",
+ "java.lang.Double",
+ "java.lang.Float",
+ "java.lang.Integer",
+ "java.lang.Long",
"java.lang.Number",
- "java.math.BigInteger",
- "java.math.BigDecimal",
- "java.lang.StringBuffer",
+ "java.lang.Object",
+ "java.lang.Object",
+ "java.lang.Short",
+ "java.lang.StackTraceElement",
"java.lang.String",
- "java.lang.reflect.Method",
+ "java.lang.StringBuffer",
+ "java.lang.StringBuilder",
+ "java.lang.Throwable",
+ "java.lang.Void",
+ "java.lang.Void",
Review comment:
Duplicate `java.lang.Void`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #857: Fix #787 JSon
XStream dataformat support
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #857: Fix #787 JSon XStream dataformat support
URL: https://github.com/apache/camel-quarkus/pull/857#issuecomment-596191795
a53b54e fixes issues found by @jamesnetherton
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #857: Fix #787 JSon
XStream dataformat support
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #857: Fix #787 JSon XStream dataformat support
URL: https://github.com/apache/camel-quarkus/pull/857#issuecomment-596191391
> is the itest module referenced in the PR workflow
Good catch, it is not. And the groovy check was not executed because it was inside `<pluginManagement>` block. Adding a fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #857:
Fix #787 JSon XStream dataformat support
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #857: Fix #787 JSon XStream dataformat support
URL: https://github.com/apache/camel-quarkus/pull/857#discussion_r389357086
##########
File path: extensions/xstream/runtime/src/main/resources/META-INF/quarkus-extension.yaml
##########
@@ -0,0 +1,27 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+---
+name: "Camel Quarkus XStream"
+description: "Camel WebSocket XStream support"
Review comment:
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull
request #857: Fix #787 JSon XStream dataformat support
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #857: Fix #787 JSon XStream dataformat support
URL: https://github.com/apache/camel-quarkus/pull/857#discussion_r389050547
##########
File path: extensions/support/xstream/deployment/src/main/java/org/apache/camel/quarkus/support/xstream/deployment/XStreamSupportProcessor.java
##########
@@ -116,57 +89,71 @@ void process(CombinedIndexBuildItem indexBuildItem,
"com.thoughtworks.xstream.converters.time.ThaiBuddhistDateConverter",
"com.thoughtworks.xstream.converters.time.YearConverter",
"com.thoughtworks.xstream.converters.time.YearMonthConverter",
- "com.thoughtworks.xstream.converters.time.ZonedDateTimeConverter",
"com.thoughtworks.xstream.converters.time.ZoneIdConverter",
- "java.lang.Void",
- "java.lang.Object",
+ "com.thoughtworks.xstream.converters.time.ZonedDateTimeConverter",
+ "com.thoughtworks.xstream.core.ClassLoaderReference",
+ "com.thoughtworks.xstream.core.JVM",
+ "com.thoughtworks.xstream.core.JVM$Test",
+ "com.thoughtworks.xstream.core.util.Base64JavaUtilCodec",
+ "com.thoughtworks.xstream.core.util.CustomObjectOutputStream",
+ "com.thoughtworks.xstream.mapper.AnnotationConfiguration",
+ "com.thoughtworks.xstream.mapper.Mapper",
+ "com.thoughtworks.xstream.mapper.Mapper$Null",
+ "com.thoughtworks.xstream.security.AnyTypePermission",
+ "com.thoughtworks.xstream.security.ArrayTypePermission",
+ "com.thoughtworks.xstream.security.ExplicitTypePermission",
+ "com.thoughtworks.xstream.security.ForbiddenClassException",
+ "com.thoughtworks.xstream.security.InterfaceTypePermission",
+ "com.thoughtworks.xstream.security.NoPermission",
+ "com.thoughtworks.xstream.security.NoTypePermission",
+ "com.thoughtworks.xstream.security.NullPermission",
+ "com.thoughtworks.xstream.security.PrimitiveTypePermission",
+ "com.thoughtworks.xstream.security.ProxyTypePermission",
+ "com.thoughtworks.xstream.security.RegExpTypePermission",
+ "com.thoughtworks.xstream.security.TypeHierarchyPermission",
+ "com.thoughtworks.xstream.security.TypePermission",
+ "com.thoughtworks.xstream.security.WildcardTypePermission",
"java.awt.Color",
- "javax.swing.LookAndFeel",
- "java.sql.Date",
+ "java.awt.Font",
+ "java.awt.font.TextAttribute",
+ "java.io.File",
+ "java.lang.Boolean",
+ "java.lang.Byte",
+ "java.lang.Character",
+ "java.lang.Double",
+ "java.lang.Float",
+ "java.lang.Integer",
+ "java.lang.Long",
"java.lang.Number",
- "java.math.BigInteger",
- "java.math.BigDecimal",
- "java.lang.StringBuffer",
+ "java.lang.Object",
+ "java.lang.Object",
Review comment:
Duplicate `java.lang.Object`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton commented on issue #857: Fix #787
JSon XStream dataformat support
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on issue #857: Fix #787 JSon XStream dataformat support
URL: https://github.com/apache/camel-quarkus/pull/857#issuecomment-595910425
In addition to the review comments, is the itest module referenced in the PR workflow? I don't see it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull
request #857: Fix #787 JSon XStream dataformat support
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #857: Fix #787 JSon XStream dataformat support
URL: https://github.com/apache/camel-quarkus/pull/857#discussion_r389081025
##########
File path: extensions/xstream/runtime/src/main/resources/META-INF/quarkus-extension.yaml
##########
@@ -0,0 +1,27 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+---
+name: "Camel Quarkus XStream"
+description: "Camel WebSocket XStream support"
Review comment:
I guess this should be `Camel XStream support`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #857: Fix #787 JSon
XStream dataformat support
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #857: Fix #787 JSon XStream dataformat support
URL: https://github.com/apache/camel-quarkus/pull/857#issuecomment-595896003
d60af9a removed the dup reflection registrations in XStreamSupportProcessor. Thx for catching those @jamesnetherton!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #857:
Fix #787 JSon XStream dataformat support
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #857: Fix #787 JSon XStream dataformat support
URL: https://github.com/apache/camel-quarkus/pull/857#discussion_r389064000
##########
File path: extensions/support/xstream/deployment/src/main/java/org/apache/camel/quarkus/support/xstream/deployment/XStreamSupportProcessor.java
##########
@@ -116,57 +89,71 @@ void process(CombinedIndexBuildItem indexBuildItem,
"com.thoughtworks.xstream.converters.time.ThaiBuddhistDateConverter",
"com.thoughtworks.xstream.converters.time.YearConverter",
"com.thoughtworks.xstream.converters.time.YearMonthConverter",
- "com.thoughtworks.xstream.converters.time.ZonedDateTimeConverter",
"com.thoughtworks.xstream.converters.time.ZoneIdConverter",
- "java.lang.Void",
- "java.lang.Object",
+ "com.thoughtworks.xstream.converters.time.ZonedDateTimeConverter",
+ "com.thoughtworks.xstream.core.ClassLoaderReference",
+ "com.thoughtworks.xstream.core.JVM",
+ "com.thoughtworks.xstream.core.JVM$Test",
+ "com.thoughtworks.xstream.core.util.Base64JavaUtilCodec",
+ "com.thoughtworks.xstream.core.util.CustomObjectOutputStream",
+ "com.thoughtworks.xstream.mapper.AnnotationConfiguration",
+ "com.thoughtworks.xstream.mapper.Mapper",
+ "com.thoughtworks.xstream.mapper.Mapper$Null",
+ "com.thoughtworks.xstream.security.AnyTypePermission",
+ "com.thoughtworks.xstream.security.ArrayTypePermission",
+ "com.thoughtworks.xstream.security.ExplicitTypePermission",
+ "com.thoughtworks.xstream.security.ForbiddenClassException",
+ "com.thoughtworks.xstream.security.InterfaceTypePermission",
+ "com.thoughtworks.xstream.security.NoPermission",
+ "com.thoughtworks.xstream.security.NoTypePermission",
+ "com.thoughtworks.xstream.security.NullPermission",
+ "com.thoughtworks.xstream.security.PrimitiveTypePermission",
+ "com.thoughtworks.xstream.security.ProxyTypePermission",
+ "com.thoughtworks.xstream.security.RegExpTypePermission",
+ "com.thoughtworks.xstream.security.TypeHierarchyPermission",
+ "com.thoughtworks.xstream.security.TypePermission",
+ "com.thoughtworks.xstream.security.WildcardTypePermission",
"java.awt.Color",
- "javax.swing.LookAndFeel",
- "java.sql.Date",
+ "java.awt.Font",
+ "java.awt.font.TextAttribute",
+ "java.io.File",
+ "java.lang.Boolean",
+ "java.lang.Byte",
+ "java.lang.Character",
+ "java.lang.Double",
+ "java.lang.Float",
+ "java.lang.Integer",
+ "java.lang.Long",
"java.lang.Number",
- "java.math.BigInteger",
- "java.math.BigDecimal",
- "java.lang.StringBuffer",
+ "java.lang.Object",
+ "java.lang.Object",
Review comment:
Haha, I knew why I was sorting them!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services