You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "vahmed-hamdy (via GitHub)" <gi...@apache.org> on 2024/12/09 15:35:19 UTC
[PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.18 [flink-connector-elasticsearch]
vahmed-hamdy opened a new pull request, #113:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/113
This ports #110 to branch v3.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.18 [flink-connector-elasticsearch]
Posted by "vahmed-hamdy (via GitHub)" <gi...@apache.org>.
vahmed-hamdy closed pull request #113: [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.18
URL: https://github.com/apache/flink-connector-elasticsearch/pull/113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.18 [flink-connector-elasticsearch]
Posted by "vahmed-hamdy (via GitHub)" <gi...@apache.org>.
vahmed-hamdy commented on code in PR #113:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/113#discussion_r1876236366
##########
.github/workflows/weekly.yml:
##########
@@ -30,27 +30,21 @@ jobs:
strategy:
matrix:
flink_branches: [{
- flink: 1.18-SNAPSHOT,
- jdk: '8, 11, 17',
- branch: main
- }, {
flink: 1.19-SNAPSHOT,
- jdk: '8, 11, 17, 21',
branch: main
}, {
flink: 1.20-SNAPSHOT,
- jdk: '8, 11, 17, 21',
branch: main
- }, {
- flink: 1.18.1,
- branch: v3.0
}, {
flink: 1.19.0,
branch: v3.0
Review Comment:
yeah, good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.18 [flink-connector-elasticsearch]
Posted by "dannycranmer (via GitHub)" <gi...@apache.org>.
dannycranmer commented on code in PR #113:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/113#discussion_r1876228825
##########
.github/workflows/weekly.yml:
##########
@@ -30,27 +30,21 @@ jobs:
strategy:
matrix:
flink_branches: [{
- flink: 1.18-SNAPSHOT,
- jdk: '8, 11, 17',
- branch: main
- }, {
flink: 1.19-SNAPSHOT,
- jdk: '8, 11, 17, 21',
branch: main
}, {
flink: 1.20-SNAPSHOT,
- jdk: '8, 11, 17, 21',
branch: main
- }, {
- flink: 1.18.1,
- branch: v3.0
}, {
flink: 1.19.0,
branch: v3.0
Review Comment:
Do we want v3.1 here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.18 [flink-connector-elasticsearch]
Posted by "vahmed-hamdy (via GitHub)" <gi...@apache.org>.
vahmed-hamdy commented on PR #113:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/113#issuecomment-2820685331
no longer needed after [3.1 release](https://github.com/apache/flink-connector-elasticsearch/commit/a154eeeeaafc78cb2281b5b4d614829458e057e3)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org