You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/03/30 12:30:22 UTC
[GitHub] [incubator-doris] kangkaisen opened a new pull request #3232:
Rewrite count distinct bitmap and hll in order by and having
kangkaisen opened a new pull request #3232: Rewrite count distinct bitmap and hll in order by and having
URL: https://github.com/apache/incubator-doris/pull/3232
For https://github.com/apache/incubator-doris/issues/3231
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #3232:
Rewrite count distinct bitmap and hll in order by and having
Posted by GitBox <gi...@apache.org>.
imay commented on a change in pull request #3232: Rewrite count distinct bitmap and hll in order by and having
URL: https://github.com/apache/incubator-doris/pull/3232#discussion_r401361127
##########
File path: fe/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java
##########
@@ -262,6 +262,11 @@ public boolean isCountDistinctBitmapOrHLL() {
return false;
}
+ // if expr isn't analyzed, the type is INVALID
+ if (!getChild(0).isAnalyzed) {
+ getChild(0).analyzeNoThrow(analyzer);
Review comment:
I'm not sure if it is OK to analyze it here.
Is it possible to call this function after analyzed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen closed pull request #3232: Rewrite
count distinct bitmap and hll in order by and having
Posted by GitBox <gi...@apache.org>.
kangkaisen closed pull request #3232: Rewrite count distinct bitmap and hll in order by and having
URL: https://github.com/apache/incubator-doris/pull/3232
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen opened a new pull request #3232:
Rewrite count distinct bitmap and hll in order by and having
Posted by GitBox <gi...@apache.org>.
kangkaisen opened a new pull request #3232: Rewrite count distinct bitmap and hll in order by and having
URL: https://github.com/apache/incubator-doris/pull/3232
For https://github.com/apache/incubator-doris/issues/3231
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay merged pull request #3232: Rewrite count
distinct bitmap and hll in order by and having
Posted by GitBox <gi...@apache.org>.
imay merged pull request #3232: Rewrite count distinct bitmap and hll in order by and having
URL: https://github.com/apache/incubator-doris/pull/3232
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on a change in pull request
#3232: Rewrite count distinct bitmap and hll in order by and having
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on a change in pull request #3232: Rewrite count distinct bitmap and hll in order by and having
URL: https://github.com/apache/incubator-doris/pull/3232#discussion_r401377806
##########
File path: fe/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java
##########
@@ -262,6 +262,11 @@ public boolean isCountDistinctBitmapOrHLL() {
return false;
}
+ // if expr isn't analyzed, the type is INVALID
+ if (!getChild(0).isAnalyzed) {
+ getChild(0).analyzeNoThrow(analyzer);
Review comment:
I also considered this problem,But I think wrong before.
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org