You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2015/09/25 10:25:53 UTC

[GitHub] incubator-zeppelin pull request: [WIP] Improve/split paragraph htm...

GitHub user corneadoug opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/324

    [WIP] Improve/split paragraph html

    Paragraph has been for long time a difficult part of Zeppelin-web code base.
    Both Html and JS are quite big, and can be hard to understand.
    This PR is splitting the paragraph HTML code into sub-modules.
    This will be a first step before starting to refactor paragraph.js

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/corneadoug/incubator-zeppelin improve/SplitParagraphHtml

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/324.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #324
    
----
commit ab45a14a85bbb30d1fb0bce1daa092b067d37d99
Author: Damien Corneau <co...@gmail.com>
Date:   2015-09-24T08:36:36Z

    Split Chart Selector and Paragraph Controls

commit 300883be3ddd4f5d103a051f7dc57edc836a9206
Author: Damien Corneau <co...@gmail.com>
Date:   2015-09-25T08:21:01Z

    Separate progress Bar

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Improve/split paragraph html

Posted by corneadoug <gi...@git.apache.org>.

Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/324#issuecomment-163826291
  
    \o/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Improve/split paragraph html

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/324


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Improve/split paragraph html

Posted by corneadoug <gi...@git.apache.org>.

Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/324#issuecomment-161569728
  
    This is ready.
    
    Since its a refactoring, It will probably need to be rebased until right before merge (since any change in zeppelin-web might cause a conflict)
    
    Also, once its merged, all the PR that has changes in zeppelin-web and created before the merge will need to be rebased.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Improve/split paragraph html

Posted by corneadoug <gi...@git.apache.org>.

GitHub user corneadoug reopened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/324

    Improve/split paragraph html

    Paragraph has been for long time a difficult part of Zeppelin-web code base.
    Both Html and JS are quite big, and can be hard to understand.
    This PR is splitting the paragraph HTML code into sub-modules.
    This will be a first step before starting to refactor paragraph.js

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/corneadoug/incubator-zeppelin improve/SplitParagraphHtml

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/324.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #324
    
----
commit f7a22b334fda0525b1860f67c7d300b49e4c2642
Author: Damien Corneau <co...@gmail.com>
Date:   2015-09-24T08:36:36Z

    Split Chart Selector and Paragraph Controls

commit 6489f7d3ec004dd261f2256744d49c16d4485cf7
Author: Damien Corneau <co...@gmail.com>
Date:   2015-09-25T08:21:01Z

    Separate progress Bar

commit 938c5e6136a522413269e28c4f0438920e438533
Author: Damien Corneau <co...@gmail.com>
Date:   2015-10-01T07:35:22Z

    Fix z-index of paragraph settings and progressbar

commit b91fb4715b2be684509e307d2e5e24f6d7bdf77e
Author: Damien Corneau <co...@gmail.com>
Date:   2015-10-01T08:43:59Z

    Fix z-index of for nvtooltip

commit b74d826ba26593de50a06d47c6aad31a63269598
Author: Damien Corneau <co...@gmail.com>
Date:   2015-10-02T02:03:36Z

    Fix z-index levels

commit 95366eeb4e849bc8be1a3b3b9ce6f91842e48c47
Author: Damien Corneau <co...@gmail.com>
Date:   2015-10-02T02:04:36Z

    Add license in new files

commit 29778c7cfd988a649aa29bfe5bf35ee895a79a27
Author: Damien CORNEAU <co...@gmail.com>
Date:   2015-12-03T08:32:36Z

    Finish spliting paragraph + split notebook actionbar

commit 37036f0aa8eff69b977124ff7cdf0532ea698a72
Author: Damien CORNEAU <co...@gmail.com>
Date:   2015-12-03T08:56:40Z

    Fix ActionBar Z-index after rebase broke it

commit 4408543be0cc23820c7d10ef953adbb665cef00e
Author: Damien CORNEAU <co...@gmail.com>
Date:   2015-12-03T09:40:13Z

    Fix Empty HTML result when slow page loading

commit 4c78cebea4fe08071f1f42edf6d03811b24185c9
Author: Damien CORNEAU <co...@gmail.com>
Date:   2015-12-03T09:45:44Z

    Add Header on new files

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Improve/split paragraph html

Posted by corneadoug <gi...@git.apache.org>.

Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/324#issuecomment-161909843
  
    Seems I have a Timeout failing test, any idea?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Improve/split paragraph html

Posted by corneadoug <gi...@git.apache.org>.

Github user corneadoug closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/324


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Improve/split paragraph html

Posted by corneadoug <gi...@git.apache.org>.

GitHub user corneadoug reopened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/324

    Improve/split paragraph html

    Paragraph has been for long time a difficult part of Zeppelin-web code base.
    Both Html and JS are quite big, and can be hard to understand.
    This PR is splitting the paragraph HTML code into sub-modules.
    This will be a first step before starting to refactor paragraph.js

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/corneadoug/incubator-zeppelin improve/SplitParagraphHtml

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/324.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #324
    
----
commit 5ef46dbc241cb5d39508c0500ef9d047ba48fbd8
Author: Damien Corneau <co...@gmail.com>
Date:   2015-09-24T08:36:36Z

    Split Chart Selector and Paragraph Controls

commit 11abc299e83ba4d5ed5aee86f146db7cc1bec43b
Author: Damien Corneau <co...@gmail.com>
Date:   2015-09-25T08:21:01Z

    Separate progress Bar

commit c44d95afa7104c5026e7b646db31b888fca217ba
Author: Damien Corneau <co...@gmail.com>
Date:   2015-10-01T07:35:22Z

    Fix z-index of paragraph settings and progressbar

commit fd62ff0ba9d7e9725c56541d49a5f979d1db352d
Author: Damien Corneau <co...@gmail.com>
Date:   2015-10-01T08:43:59Z

    Fix z-index of for nvtooltip

commit cd7017e47e9b3758bf8cf53fff97072e9d4dae81
Author: Damien Corneau <co...@gmail.com>
Date:   2015-10-02T02:03:36Z

    Fix z-index levels

commit ee4cbbf96c5baf817e39dbba9eb49cde3acfe613
Author: Damien Corneau <co...@gmail.com>
Date:   2015-10-02T02:04:36Z

    Add license in new files

commit afc150e2d02c4a2f190bd429563e360c978ddaa9
Author: Damien CORNEAU <co...@gmail.com>
Date:   2015-12-03T08:32:36Z

    Finish spliting paragraph + split notebook actionbar

commit eb8febd8e29d9c007453dafd459f00857cc0ab9b
Author: Damien CORNEAU <co...@gmail.com>
Date:   2015-12-03T08:56:40Z

    Fix ActionBar Z-index after rebase broke it

commit 23a5d7b514ac0f5407139f4313e46f7a7b36870e
Author: Damien CORNEAU <co...@gmail.com>
Date:   2015-12-03T09:40:13Z

    Fix Empty HTML result when slow page loading

commit f522557ad8a381597706d2365c9766f99b6534a7
Author: Damien CORNEAU <co...@gmail.com>
Date:   2015-12-03T09:45:44Z

    Add Header on new files

commit f573178ee551791050f8a64d5c83540e08fd1838
Author: Damien CORNEAU <co...@gmail.com>
Date:   2015-12-10T07:36:53Z

    Try bumping selenium wait time for waitParagraph

commit 5592797c5e50e2e60d999846d3536b7a2c2d7de7
Author: Damien CORNEAU <co...@gmail.com>
Date:   2015-12-10T09:59:10Z

    Fix waitForParagraph xpath in selenium test

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---