You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2018/02/07 19:31:14 UTC
[Impala-ASF-CR] Revert 'IMPALA-6338: Fix flaky test profile fragment instances'
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9243
Change subject: Revert 'IMPALA-6338: Fix flaky test_profile_fragment_instances'
......................................................................
Revert 'IMPALA-6338: Fix flaky test_profile_fragment_instances'
There have been several crashes observed in testing recently, and its
not clear what's going on, so for now revert this moderately risky
change.
Change-Id: I48c11f0817c5190a3a94f8260f3e8ef653357ab3
---
M be/src/common/status.h
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/coordinator-backend-state.h
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M tests/query_test/test_observability.py
6 files changed, 18 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/9243/1
--
To view, visit http://gerrit.cloudera.org:8080/9243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I48c11f0817c5190a3a94f8260f3e8ef653357ab3
Gerrit-Change-Number: 9243
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] Revert 'IMPALA-6338: Fix flaky test profile fragment instances'
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9243 )
Change subject: Revert 'IMPALA-6338: Fix flaky test_profile_fragment_instances'
......................................................................
Revert 'IMPALA-6338: Fix flaky test_profile_fragment_instances'
There have been several crashes observed in testing recently, and its
not clear what's going on, so for now revert this moderately risky
change.
Change-Id: I48c11f0817c5190a3a94f8260f3e8ef653357ab3
Reviewed-on: http://gerrit.cloudera.org:8080/9243
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Thomas Tauber-Marshall <tm...@cloudera.com>
---
M be/src/common/status.h
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/coordinator-backend-state.h
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M tests/query_test/test_observability.py
6 files changed, 18 insertions(+), 30 deletions(-)
Approvals:
Alex Behm: Looks good to me, approved
Thomas Tauber-Marshall: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I48c11f0817c5190a3a94f8260f3e8ef653357ab3
Gerrit-Change-Number: 9243
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] Revert 'IMPALA-6338: Fix flaky test profile fragment instances'
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9243 )
Change subject: Revert 'IMPALA-6338: Fix flaky test_profile_fragment_instances'
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48c11f0817c5190a3a94f8260f3e8ef653357ab3
Gerrit-Change-Number: 9243
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Feb 2018 19:32:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert 'IMPALA-6338: Fix flaky test profile fragment instances'
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9243 )
Change subject: Revert 'IMPALA-6338: Fix flaky test_profile_fragment_instances'
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48c11f0817c5190a3a94f8260f3e8ef653357ab3
Gerrit-Change-Number: 9243
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Feb 2018 20:06:45 +0000
Gerrit-HasComments: No